Fixing review comments

microsoft · Oct 12, 2023 · 0e712cb · 0e712cb
1 parent 5475631
commit 0e712cb
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/packages/react-charting/src/components/AreaChart/AreaChart.base.tsx b/packages/react-charting/src/components/AreaChart/AreaChart.base.tsx
@@ -178,7 +178,6 @@ export class AreaChartBase extends React.Component<IAreaChartProps, IAreaChartSt
         'data-is-focusable': true,
         xAxisCalloutAccessibilityData: this.state.xAxisCalloutAccessibilityData,
         ...this.props.calloutProps,
-        descriptionMessage: this.state.YValueHover!.length > 1 ? 'Shown Y values are cumulative' : undefined,
       };
       return (
         <CartesianChart

diff --git a/packages/react-charting/src/components/CommonComponents/CartesianChart.types.ts b/packages/react-charting/src/components/CommonComponents/CartesianChart.types.ts
@@ -373,7 +373,9 @@ export interface ICartesianChartProps {
   /**
    * Callout customization props
    */
-  calloutProps?: Partial<ICalloutProps>;
+  calloutProps?: Partial<ICalloutProps> & {
+    descriptionMessage?: string;
+  };
 
   /**
    * props for the svg; use this to include aria-* or other attributes on the tag

diff --git a/packages/react-examples/src/react-charting/AreaChart/AreaChart.DataChange.Example.tsx b/packages/react-examples/src/react-charting/AreaChart/AreaChart.DataChange.Example.tsx
@@ -98,6 +98,7 @@ export class AreaChartDataChangeExample extends React.Component<{}, IAreaChartBa
               allowFocusOnLegends: true,
             }}
             enableReflow={true}
+            calloutProps={{ descriptionMessage: 'Shown Y values are cumulative' }}
           />
           <DefaultButton text="Change Ydata" onClick={this._changeData} />
           <DefaultButton text="Change Xdata" onClick={this._changeXData} />