Skip to content

Commit

Permalink
chore(react-18-tests-v8): follow same pattern with type-check as in v…
Browse files Browse the repository at this point in the history
…9 when using path aliases
  • Loading branch information
Hotell committed Nov 24, 2022
1 parent 03a0a21 commit 3b68a5d
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 0 deletions.
17 changes: 17 additions & 0 deletions apps/react-18-tests-v8/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,20 @@ This file and process will be replaced with Storybook once we are able to get st
```

Add test files for React 18 issues that have been triaged and resolved so that we do not regress.

### `type-check`

To be able to type-check cross React versions we need all v8 libraries build up front so we don't type check all v8 implementation rather public API surface.

For that purpose we use `tsconfig.react-compat-check.json` as target for `type-check` npm script task, which disables path aliases and forces `tsc` to consume linked monorepo build packages.

**Local machine flow:**

```sh
lage build --to @fluentui/react-18-tests-v8
yarn workspace @fluentui/react-18-tests-v8 type-check
```

**CI:**

lage defines `build` targets to be executed prior to `type-check`.
7 changes: 7 additions & 0 deletions apps/react-18-tests-v8/tsconfig.react-compat-check.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"extends": "./tsconfig.app.json",
"compilerOptions": {
"noEmit": true,
"paths": {}
}
}

0 comments on commit 3b68a5d

Please sign in to comment.