fix: Allow data-selection-disabled to be respected by DetailsRow (#25836

) * fix: Allow data-selection-disabled to be respected by DetailsRow. * Adding change file. Co-authored-by: Humberto Makoto Morimoto Burgos <[email protected]>
microsoft · Nov 29, 2022 · 60b2e7d · 60b2e7d
1 parent 678f8db
commit 60b2e7d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/change/@fluentui-react-5ad3027a-0dd8-4a63-bb67-aa14172f043f.json b/change/@fluentui-react-5ad3027a-0dd8-4a63-bb67-aa14172f043f.json
@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix: Allow data-selection-disabled to be respected by DetailsRow.",
+  "packageName": "@fluentui/react",
+  "email": "[email protected]",
+  "dependentChangeType": "patch"
+}
diff --git a/packages/react/src/components/DetailsList/DetailsRow.base.tsx b/packages/react/src/components/DetailsList/DetailsRow.base.tsx
@@ -327,7 +327,7 @@ export class DetailsRowBase extends React.Component<IDetailsRowBaseProps, IDetai
         className={this._classNames.root}
         data-selection-index={itemIndex}
         data-selection-touch-invoke={true}
-        data-selection-disabled={disabled || undefined}
+        data-selection-disabled={(this.props as any)['data-selection-disabled'] ?? (disabled || undefined)}
         data-item-index={itemIndex}
         aria-rowindex={ariaPositionInSet === undefined ? itemIndex + flatIndexOffset : undefined}
         data-automationid="DetailsRow"
@@ -354,7 +354,7 @@ export class DetailsRowBase extends React.Component<IDetailsRowBaseProps, IDetai
               className: this._classNames.check,
               theme,
               isVisible: checkboxVisibility === CheckboxVisibility.always,
-              onRenderDetailsCheckbox: onRenderDetailsCheckbox,
+              onRenderDetailsCheckbox,
               useFastIcons,
             })}
           </div>
@@ -432,9 +432,7 @@ export class DetailsRowBase extends React.Component<IDetailsRowBaseProps, IDetai
     const selectionState = getSelectionState(this.props);
 
     if (!shallowCompare(selectionState, this.state.selectionState)) {
-      this.setState({
-        selectionState: selectionState,
-      });
+      this.setState({ selectionState });
     }
   };