fixup! feat(scripts): add projecType filtering to isConvergedPkg helper

microsoft · Jul 22, 2022 · 79a4462 · 79a4462
1 parent dd64082
commit 79a4462
Showing 1 changed file with 13 additions and 5 deletions.
diff --git a/scripts/monorepo/runPublished.js b/scripts/monorepo/runPublished.js
@@ -29,16 +29,24 @@ const websitePackages = [
 // in the root package.json's publishing-related scripts and will need to be updated if --scope changes.
 const beachballPackageScopes = Object.entries(getAllPackageInfo())
   .filter(([, { packageJson, packagePath }]) => {
-    // Ignore northstar
-    if (/[\\/]fluentui[\\/]/.test(packagePath)) {
+    const isNorthstar = /[\\/]fluentui[\\/]/.test(packagePath);
+
+    if (isNorthstar) {
+      return false;
+    }
+
+    if (packageJson.private === true) {
       return false;
     }
 
+    const isConverged = isConvergedPackage({ packagePathOrJson: packageJson });
     if (process.env.RELEASE_VNEXT) {
-      return isConvergedPackage({ packagePathOrJson: packageJson }) && packageJson.private !== true;
-    } else if (!isConvergedPackage({ packagePathOrJson: packageJson })) {
+      return isConverged;
+    }
+
+    if (!isConverged) {
       // v8 scope
-      return packageJson.private !== true || websitePackages.includes(packageJson.name);
+      return websitePackages.includes(packageJson.name);
     }
 
     // Ignore v9/converged packages when releasing v8