Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dropdown] Required ARIA child role not present for dropdown #19090

Closed
sijeee opened this issue Jul 23, 2021 · 2 comments
Closed

[Dropdown] Required ARIA child role not present for dropdown #19090

sijeee opened this issue Jul 23, 2021 · 2 comments

Comments

@sijeee
Copy link

sijeee commented Jul 23, 2021

Environment Information

  • OS : Windows 10
  • OS Version: 21H1 (OS Build 19043.1110)
  • Browser Version: Microsoft Edge (93.0.933.1) (Official build) (64-bit)

Describe the issue:

child of an element whose role is "combobox" needs to have an aria role of textbox

Please provide a reproduction of the issue in a codepen:

https://codepen.io/sijeee/pen/RwVjWZd

Actual behavior:

Elements with an ARIA role that require child roles does not contain them

Expected behavior:

Ensures elements with an ARIA role that require child roles contain them

Documentation describing expected behavior

https://www.w3.org/TR/wai-aria-1.1/#combobox

@max-zheng
Copy link

max-zheng commented Aug 3, 2021

Any update on this issue? My team found this same issue using Accessibility Insights for Web - FastPass scan of our website. Looking at the code, the solution may be to add the role to this span

@smhigley
Copy link
Contributor

smhigley commented Aug 4, 2021

This is a false positive from Accessibility Insights, and a dupe of #17838, #17981, #18333, and #19014. The false positive has already been fixed in axe-core (where Accessibility Insights' rules set comes from): dequelabs/axe-core#2505.

@max-zheng to your question specifically: adding textbox (whether through a role or otherwise) as a child of a combobox results in significantly worse real-world support, so I definitely wouldn't recommend adding that role to the child span :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants