You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With Form says 'Having a formulary', which I assume should be 'Having a form'.
Trigger Outside of Dialog It appears that the only thing added by DialogTrigger is the aria-haspopup="dialog". If that's the only thing added, we should note that, and not make the use of DialogTrigger sound so critical. Bug: Dialog Docs nits #25132 (comment)
opening the "Open non-modal dialog" in No Focusable Element leaves the user in a state where they have to refresh the page to return to a useable page state. While I understand that this is the lesson we're trying to teach, I feel this is a bit too much for someone that clicked the button out of curiosity. Either provide a way to close the modal, or at least warn what is about to happen. react-dialog: send focus to the dialog root when no other focusables are present #25150
We tell people not to open a dialog from a dialog. I'm glad that we have validated that it is technically possible, but we already talk about it in the 'dont' section. There is no need to have an example of it.
Trigger Outside of Dialog It appears that the only thing added by DialogTrigger is the aria-haspopup="dialog". If that's the only thing added, we should note that, and not make the use of DialogTrigger sound so critical.
It actually also includes tabster deloser attributes which will ensure proper focus behaviour.
opening the "Open non-modal dialog" in No Focusable Element leaves the user in a state where they have to refresh the page to return to a useable page state. While I understand that this is the lesson we're trying to teach, I feel this is a bit too much for someone that clicked the button out of curiosity. Either provide a way to close the modal, or at least warn what is about to happen.
We tell people not to open a dialog from a dialog. I'm glad that we have validated that it is technically possible, but we already talk about it in the 'don't' section. There is no need to have an example of it.
This is a valid point. I guess I can keep the validation on a e2e test and omit it from the storybook itself 🤔
Library
React Components / v9 (@fluentui/react-components)
The text was updated successfully, but these errors were encountered: