Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-table: reference of non-existing slot #26199

Closed
layershifter opened this issue Jan 6, 2023 · 0 comments · Fixed by #26219
Closed

react-table: reference of non-existing slot #26199

layershifter opened this issue Jan 6, 2023 · 0 comments · Fixed by #26219
Labels
Component: Table Fluent UI react-components (v9) Priority 1: High Status: Fixed Fixed in some PR Type: Bug 🐛

Comments

@layershifter
Copy link
Member

Problem

media slot does not exist.

fluentui/packages/react-components/react-table/src/components/TableSelectionCell/TableSelectionCell.types.ts

Line 21 in 3f806f9

export type TableSelectionCellProps = ComponentProps<Partial<Omit<TableSelectionCellSlots, 'media'>>> & {

ling1726 added a commit to ling1726/fluentui that referenced this issue Jan 6, 2023
@ling1726
refactor: Cleanup unused code
535e7f9 
Fixes microsoft#26199
Fixes microsoft#26200
Fixes microsoft#26201
Fixes microsoft#26204
@ling1726 ling1726 mentioned this issue Jan 6, 2023
Merged
ling1726 added a commit that referenced this issue Jan 9, 2023
@ling1726
refactor: Cleanup unused code (#26219)
2bde4a9 
* refactor: Cleanup unused code

Fixes #26199
Fixes #26200
Fixes #26201
Fixes #26204

* changefile
@msft-fluent-ui-bot msft-fluent-ui-bot added Status: Fixed Fixed in some PR and removed Status: In PR labels Jan 9, 2023
q1b pushed a commit to q1b/fluentui that referenced this issue Jan 24, 2023
@ling1726 @q1b
refactor: Cleanup unused code (microsoft#26219)
43a54e1 
* refactor: Cleanup unused code

Fixes microsoft#26199
Fixes microsoft#26200
Fixes microsoft#26201
Fixes microsoft#26204

* changefile
@microsoft microsoft locked as resolved and limited conversation to collaborators Feb 9, 2023
Hotell pushed a commit to Hotell/fluentui that referenced this issue Feb 9, 2023
@ling1726 @Hotell
refactor: Cleanup unused code (microsoft#26219)
4b47807 
* refactor: Cleanup unused code

Fixes microsoft#26199
Fixes microsoft#26200
Fixes microsoft#26201
Fixes microsoft#26204

* changefile
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Component: Table Fluent UI react-components (v9) Priority 1: High Status: Fixed Fixed in some PR Type: Bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Cleanup unused code ling1726/fluentui
3 participants
@layershifter @ling1726 @msft-fluent-ui-bot