Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Dropdown should be defined as 'read-only combobox' instead of 'editable combobox' #4262

Closed
satbai opened this issue Mar 13, 2018 · 6 comments

Comments

@satbai
Copy link

satbai commented Mar 13, 2018

Bug Report

  • Package version(s): latest
  • Browser and OS versions: Edge

Priorities and help requested (not applicable if asking question):

Are you willing to submit a PR to fix? No
Requested priority: Normal
Products/sites affected: (if applicable)

Describe the issue:

  1. Go to https://developer.microsoft.com/en-us/fabric#/components/dropdown
  2. Set focus to Basic uncontrolled example DropDown
  3. Narrator announces 'Home - Office UI Fabric - Microsoft Edge, Basic dropdown example, editable combo box,'

image

Expected behavior:

  1. It should be a read only combo box. Shouldn't editable combo box have an actual input field that you can type into.
@michaelangotti
Copy link
Collaborator

@betrue-final-final What are your thoughts?

@betrue-final-final
Copy link
Member

I agree. I meant to comment earlier that it should not be read as editable combo box. @cschlechty on whether 'read-only' means can't type values or can't use. I think this is correct but would love the double verification.

@cschlechty
Copy link
Member

aria-readonly means you can't change the value of the control. It looks correct as-is https://www.w3.org/WAI/PF/aria/states_and_properties#aria-readonly

@betrue-final-final
Copy link
Member

Ok, and "editable" specifically means it can be modified, and not just text editable?

@cschlechty
Copy link
Member

yes, i believe so

@michaelangotti
Copy link
Collaborator

@satbai According to design this is expected. Closing this issue.

@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants