Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DropDown: control type is defined as list #5266

Closed
satbai opened this issue Jun 20, 2018 · 5 comments
Closed

DropDown: control type is defined as list #5266

satbai opened this issue Jun 20, 2018 · 5 comments
Assignees

Comments

@satbai
Copy link

satbai commented Jun 20, 2018

Bug Report

  • Package version(s): latest
  • Browser and OS versions: all

Priorities and help requested:

Are you willing to submit a PR to fix? No

Requested priority: Normal

Describe the issue:

I believe the control type of the Dropdown should be combo box, at least that's what it used to be. If the current control type is correct, please provide details why.

image

If applicable, please provide a codepen repro:

https://developer.microsoft.com/en-us/fabric#/components/dropdown

@dzearing
Copy link
Member

Needs some investigation.

@dzearing dzearing changed the title Dropdown control type is defined as list DropDown: control type is defined as list Jun 21, 2018
@cliffkoh
Copy link
Contributor

Hi @satbai , could you please add more information on what is the expected and actual state, from a HTML markdown POV?

@satbai
Copy link
Author

satbai commented Jun 26, 2018

Hi @cliffkoh ,

The role attribute in the HTML element will change the control type. The current role is "listbox" and narrator will say: 

Basic dropdown example, Select an Option, selected, selection contains 0 items,

With the role "combobox" the narrator says:

Basic dropdown example, Select an Option, editable combo box,

https://www.w3.org/TR/wai-aria-practices/#combobox
https://www.w3.org/TR/wai-aria-practices/#Listbox

Since this bug got raised by our vendor test pass and I have a meeting with them tomorrow, I can ask what the correct role for this should be to make sure we're not changing the roles back and forth. It looks like the roles have been changed a few times.

Some related closed issues:
#4262
#4360
#2335

@cliffkoh
Copy link
Contributor

Hi @satbai, looking at the specs you linked to, it says that:

Combobox:

A combobox is a widget made up of the combination of two distinct elements: 1) a single-line textbox, and 2) an associated pop-up element for helping users set the value of the textbox.

Listbox:

A listbox widget presents a list of options and allows a user to select one or more of them. A listbox that allows a single option to be chosen is a single-select listbox; one that allows multiple options to be selected is a multi-select listbox.

Our Dropdown does not have a listbox in it (we do have a separate ComboBox component that does have the textbox). As such, the current role should be correct.

@cliffkoh
Copy link
Contributor

Please also look at #5354 where I discuss the role at greater depth.

@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants