-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DropDown: control type is defined as list #5266
Comments
Needs some investigation. |
Hi @satbai , could you please add more information on what is the expected and actual state, from a HTML markdown POV? |
Hi @cliffkoh , The role attribute in the HTML element will change the control type. The current role is "listbox" and narrator will say:
With the role "combobox" the narrator says:
https://www.w3.org/TR/wai-aria-practices/#combobox Since this bug got raised by our vendor test pass and I have a meeting with them tomorrow, I can ask what the correct role for this should be to make sure we're not changing the roles back and forth. It looks like the roles have been changed a few times. |
Hi @satbai, looking at the specs you linked to, it says that: Combobox:
Listbox:
Our Dropdown does not have a listbox in it (we do have a separate ComboBox component that does have the textbox). As such, the current role should be correct. |
Please also look at #5354 where I discuss the |
Bug Report
Priorities and help requested:
Are you willing to submit a PR to fix? No
Requested priority: Normal
Describe the issue:
I believe the control type of the Dropdown should be combo box, at least that's what it used to be. If the current control type is correct, please provide details why.
If applicable, please provide a codepen repro:
https://developer.microsoft.com/en-us/fabric#/components/dropdown
The text was updated successfully, but these errors were encountered: