Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running prettier in charting package #15071

Merged
merged 7 commits into from
Sep 16, 2020
Merged

Running prettier in charting package #15071

merged 7 commits into from
Sep 16, 2020

Conversation

czearing
Copy link
Collaborator

@czearing czearing commented Sep 16, 2020 •
edited
Loading

Pull request checklist

  • Include a change request file using $ yarn change

Description of changes

  1. Running prettier in VerticalBarChart.base.tsx and Legends.styles.ts
  2. Updating @fluentui/eslint-plugin to 0.54.1 in a11y-testing and a11y-rules packages.

@czearing czearing requested a review from Raghurk as a code owner September 16, 2020 17:16
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 16, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 00aea04:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration
microsoft/fluentui: codesandbox-react-next-template Configuration
microsoft/fluentui: codesandbox-react-northstar-template Configuration

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f79009c:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration
microsoft/fluentui: codesandbox-react-next-template Configuration
microsoft/fluentui: codesandbox-react-northstar-template Configuration

@ecraig12345 ecraig12345 merged commit a206613 into microsoft:master Sep 16, 2020
@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 872 909 5000
Breadcrumb mount 39220 40156 5000
BreadcrumbNext mount 149482 149572 5000
ButtonNext mount 561 596 5000
Checkbox mount 1582 1567 5000
CheckboxBase mount 1341 1317 5000
CheckboxNext mount 1512 1517 5000
ChoiceGroup mount 4945 4949 5000
ChoiceGroupNext mount 5017 5004 5000
ComboBox mount 927 931 1000
CommandBar mount 7337 7314 1000
ContextualMenu mount 12283 12266 1000
DefaultButton mount 1106 1104 5000
DetailsRow mount 3435 3513 5000
DetailsRowFast mount 3448 3478 5000
DetailsRowNoStyles mount 3302 3352 5000
Dialog mount 1481 1456 1000
DocumentCardTitle mount 1755 1744 1000
Dropdown mount 2573 2580 5000
FocusZone mount 1705 1715 5000
IconButton mount 1794 1760 5000
Label mount 351 318 5000
Link mount 437 450 5000
LinkNext mount 472 456 5000
MenuButton mount 1436 1444 5000
MessageBar mount 1975 1992 5000
MessageBarNext mount 1958 1957 5000
Nav mount 3305 3153 1000
OverflowSet mount 1365 1387 5000
OverflowSetNext mount 1012 1008 5000
Panel mount 1401 1447 1000
Persona mount 824 839 1000
Pivot mount 1383 1413 1000
PivotNext mount 1359 1391 1000
PrimaryButton mount 1276 1266 5000
Rating mount 7791 7625 5000
RatingNext mount 7581 7471 5000
SearchBox mount 1287 1286 5000
SearchBoxNext mount 1340 1428 5000
Shimmer mount 2602 2574 5000
ShimmerNext mount 2573 2561 5000
Slider mount 1454 1465 5000
SliderNext mount 1886 1857 5000
SpinButton mount 5314 4902 5000
SpinButtonNext mount 5017 4968 5000
Spinner mount 381 402 5000
SplitButton mount 3091 3062 5000
Stack mount 520 520 5000
StackWithIntrinsicChildren mount 1817 1862 5000
StackWithTextChildren mount 4971 5013 5000
SwatchColorPicker mount 10219 10147 5000
SwatchColorPickerNext mount 10003 10085 5000
TagPicker mount 2626 2731 5000
TeachingBubble mount 47444 47514 5000
TeachingBubbleNext mount 48040 47916 5000
Text mount 433 413 5000
TextField mount 1391 1367 5000
ThemeProvider mount 4510 4526 5000
ThemeProvider virtual-rerender 515 492 5000
Toggle mount 836 839 5000
ToggleNext mount 807 789 5000
button mount 119 114 5000

Perf Analysis (Fluent)

⚠️ 5 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
ButtonOverridesMissPerf.default 1654 42 39.38:1 analysis
ButtonUseCssNestingPerf.default 1086 43 25.26:1 analysis
ButtonUseCssPerf.default 829 43 19.28:1 analysis
ChatWithPopoverPerf.default 492 460 1.07:1 analysis
ListNestedPerf.default 602 871 0.69:1 analysis
Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.45 0.47 0.96:1 2000 908
🦄 Button.Fluent 0.12 0.19 0.63:1 5000 597
🔧 Checkbox.Fluent 0.62 0.38 1.63:1 1000 624
🎯 Dialog.Fluent 0.17 0.23 0.74:1 5000 828
🔧 Dropdown.Fluent 2.83 0.48 5.9:1 1000 2833
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 759
🦄 Image.Fluent 0.08 0.12 0.67:1 5000 422
🔧 Slider.Fluent 1.51 0.36 4.19:1 1000 1505
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 392
🦄 Tooltip.Fluent 0.11 14.68 0.01:1 5000 560

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
PortalMinimalPerf.default 156 109 1.43:1
AttachmentMinimalPerf.default 197 151 1.3:1
RefMinimalPerf.default 240 186 1.29:1
DividerMinimalPerf.default 428 344 1.24:1
ImageMinimalPerf.default 455 371 1.23:1
BoxMinimalPerf.default 405 335 1.21:1
FormMinimalPerf.default 474 394 1.2:1
HeaderMinimalPerf.default 419 349 1.2:1
SegmentMinimalPerf.default 397 333 1.19:1
TableMinimalPerf.default 459 386 1.19:1
ReactionMinimalPerf.default 447 378 1.18:1
FlexMinimalPerf.default 331 282 1.17:1
RadioGroupMinimalPerf.default 470 402 1.17:1
TextMinimalPerf.default 390 332 1.17:1
LabelMinimalPerf.default 460 398 1.16:1
Text.Fluent 392 338 1.16:1
Tooltip.Fluent 560 483 1.16:1
AccordionMinimalPerf.default 165 143 1.15:1
AnimationMinimalPerf.default 436 380 1.15:1
StatusMinimalPerf.default 774 673 1.15:1
ChatDuplicateMessagesPerf.default 466 408 1.14:1
TooltipMinimalPerf.default 839 735 1.14:1
ButtonMinimalPerf.default 193 171 1.13:1
ChatMinimalPerf.default 666 588 1.13:1
LayoutMinimalPerf.default 431 380 1.13:1
TextAreaMinimalPerf.default 543 479 1.13:1
ListMinimalPerf.default 530 473 1.12:1
Image.Fluent 422 378 1.12:1
CardMinimalPerf.default 614 554 1.11:1
GridMinimalPerf.default 378 342 1.11:1
Dialog.Fluent 828 749 1.11:1
ProviderMinimalPerf.default 919 835 1.1:1
SkeletonMinimalPerf.default 460 420 1.1:1
IconMinimalPerf.default 734 667 1.1:1
Button.Fluent 597 544 1.1:1
DialogMinimalPerf.default 824 763 1.08:1
Icon.Fluent 759 703 1.08:1
AlertMinimalPerf.default 317 297 1.07:1
CarouselMinimalPerf.default 472 443 1.07:1
HeaderSlotsPerf.default 855 796 1.07:1
PopupMinimalPerf.default 691 645 1.07:1
ToolbarMinimalPerf.default 1006 938 1.07:1
ItemLayoutMinimalPerf.default 1313 1244 1.06:1
MenuMinimalPerf.default 902 848 1.06:1
MenuButtonMinimalPerf.default 1598 1512 1.06:1
ProviderMergeThemesPerf.default 1861 1761 1.06:1
TreeMinimalPerf.default 928 878 1.06:1
AttachmentSlotsPerf.default 1201 1152 1.04:1
AvatarMinimalPerf.default 487 467 1.04:1
LoaderMinimalPerf.default 741 710 1.04:1
SplitButtonMinimalPerf.default 3838 3707 1.04:1
CustomToolbarPrototype.default 3619 3475 1.04:1
ButtonSlotsPerf.default 615 598 1.03:1
CheckboxMinimalPerf.default 2855 2774 1.03:1
DropdownManyItemsPerf.default 766 747 1.03:1
Avatar.Fluent 908 879 1.03:1
InputMinimalPerf.default 1269 1239 1.02:1
SliderMinimalPerf.default 1497 1470 1.02:1
DropdownMinimalPerf.default 2814 2779 1.01:1
TableManyItemsPerf.default 2273 2259 1.01:1
TreeWith60ListItems.default 218 216 1.01:1
VideoMinimalPerf.default 645 637 1.01:1
Dropdown.Fluent 2833 2802 1.01:1
EmbedMinimalPerf.default 1937 1928 1:1
Checkbox.Fluent 624 625 1:1
Slider.Fluent 1505 1499 1:1
ListWith60ListItems.default 936 1069 0.88:1
ListCommonPerf.default 697 951 0.73:1

@size-auditor
Copy link

size-auditor bot commented Sep 16, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 714236544d77f30c228e051559e145807f23e24a (build)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes

@Raghurk Raghurk Awaiting requested review from Raghurk

@dzearing dzearing Awaiting requested review from dzearing

Assignees
No one assigned
Labels
Package: charting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@czearing @msft-github-bot @ecraig12345