Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nav in high contrast according the changes in master branch #15265

Conversation

Leolewin
Copy link
Contributor

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Port 13850 to update Nav to latest redlines in office-ui-fabric-react/5.79.1

Focus areas to test

(optional)

@ghost
Copy link

ghost commented Sep 27, 2020

CLA assistant check
All CLA requirements met.

Copy link
Member

@khmakoto khmakoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this fix, but due to work we're currently doing to prepare master for our version 8 beta release, we're asking contributors to either wait a couple weeks to submit fixes (if it's not urgent) or submit to the new 7.0 branch (if it's urgent). See #15222 for more details.

@msft-github-bot
Copy link
Contributor

This pull request has been automatically marked as stale because it was marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 5 days of this comment. Thank you for your contributions to Fluent UI!

@Leolewin
Copy link
Contributor Author

Thanks for submitting this fix, but due to work we're currently doing to prepare master for our version 8 beta release, we're asking contributors to either wait a couple weeks to submit fixes (if it's not urgent) or submit to the new 7.0 branch (if it's urgent). See #15222 for more details.

Hi, @khmakoto , how about the feedback of version 8 beta release? We have a accessibility bug in SharePoint 2019 caused by it and this PR is sent to settle the issue. I have sent a email to fabric team before and didn't get any response. So is there any one who can review my changes, reopen this PR and merge it into branch microsoft:office-ui-fabric-react_v5.79.1? Thanks

@khmakoto
Copy link
Member

Hi @Leolewin, didn't meant for the PR to close, I've reopened it for now after seeing that another branch is being targeted. Sorry for that.

@ecraig12345 are you the one that should review this change?

@Leolewin
Copy link
Contributor Author

Hi @Leolewin, didn't meant for the PR to close, I've reopened it for now after seeing that another branch is being targeted. Sorry for that.

@ecraig12345 are you the one that should review this change?

@khmakoto Thanks for your great help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants