SearchBox: role=search is removed, but can be optionally defined via role prop. #15450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzearing
requested review from
assuncaocharles,
behowell,
bigbadcapers,
chrisdholt,
ecraig12345,
evlevy,
hyoshis,
Jacqueline-ms,
Jahnp,
JasonGore,
joschect,
jurokapsiar,
khmakoto,
kolaps33,
layershifter,
lorejoh12,
miroslavstastny,
pompomon,
Raghurk,
wsmd and
xugao
as code owners
|
I think you have the wrong base branch. |
|
I mean it looks like your local branch for this PR was based off of master. It should be based off of 7.0. |
ecraig12345
removed request for
hyoshis,
jurokapsiar,
layershifter,
bigbadcapers,
joschect,
kolaps33,
JasonGore,
Jacqueline-ms,
evlevy and
behowell
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changes
Baseline commit: 40edbe0aa78c0d1a56a3609318431fb4ceb4abe5 (build) |
khmakoto
approved these changes
Oct 9, 2020
40 tasks
Ridvanovskyy
approved these changes
Oct 9, 2020
ecraig12345
reviewed
Oct 9, 2020
packages/office-ui-fabric-react/src/components/SearchBox/SearchBox.base.tsx
Show resolved
Hide resolved
Ridvanovskyy
approved these changes
Oct 9, 2020
ecraig12345
reviewed
Oct 9, 2020
|
🎉 Handy links: |
|
🎉 Handy links: |
2 tasks
msft-github-bot
pushed a commit
that referenced
this pull request
Oct 20, 2020
<!-- !!!!!!! IMPORTANT !!!!!!! Due to work we're currently doing to prepare master branch for our version 8 beta release, please hold-off submitting the PR until around October 12 if it's not urgent. If it is urgent, please submit the PR targeting the 7.0 branch. This change does not apply to react-northstar contributors. See #15222 for more details. Sorry for the inconvenience and short notice. --> #### Pull request checklist - [ ] Addresses an existing issue: Fixes #0000 - [x] Include a change request file using `$ yarn change` #### Description of changes _Cherry-pick of #15450._ _Original PR description:_ ## Before: This JSX: ``` <SearchBox /> ``` Renders this HTML: ```jsx <div role="search"> <input ... /> </div> ``` ## After: This JSX: ``` <SearchBox /> <SearchBox role="search" /> ``` Renders this HTML: ```jsx <div> <input ... /> </div> <div role="search"> <input ... /> </div> ```
SethDonohue
pushed a commit
to SethDonohue/fluentui
that referenced
this pull request
Nov 2, 2020
<!-- !!!!!!! IMPORTANT !!!!!!! Due to work we're currently doing to prepare master branch for our version 8 beta release, please hold-off submitting the PR until around October 12 if it's not urgent. If it is urgent, please submit the PR targeting the 7.0 branch. This change does not apply to react-northstar contributors. See microsoft#15222 for more details. Sorry for the inconvenience and short notice. --> #### Pull request checklist - [ ] Addresses an existing issue: Fixes #0000 - [x] Include a change request file using `$ yarn change` #### Description of changes _Cherry-pick of microsoft#15450._ _Original PR description:_ ## Before: This JSX: ``` <SearchBox /> ``` Renders this HTML: ```jsx <div role="search"> <input ... /> </div> ``` ## After: This JSX: ``` <SearchBox /> <SearchBox role="search" /> ``` Renders this HTML: ```jsx <div> <input ... /> </div> <div role="search"> <input ... /> </div> ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Before:
This JSX:
Renders this HTML:
After:
This JSX:
Renders this HTML: