adding lines in vertical stacked bar chart complex combo chart #15551
Conversation
msft-github-bot
added
the
needs cherry-pick
shivasai09
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 59b260b:
|
Perf AnalysisNo significant results to display. All results
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: cdd4bc1d6b7eb991527d6d9ebb59709854fd3a16 (build) |
…react into user/v-sivsar/addingLinesInVerticalStackedbarr
|
Now that we're publishing beta versions of 8.0 please also port this to the master branch once it merges. |
| if (_isHavingLines) { | ||
| if (this.state.isLegendSelected) { | ||
| shouldFocusStackOnly = false; | ||
| } else { |
There was a problem hiding this comment.
shouldFocusStackOnly= this.state.isLegendSelected
| // we inject index also , it will be helpful to draw lines when x asix is | ||
| // of string type | ||
| linesData.forEach((line: LineData) => { | ||
| if (line.x === undefined) { |
| } | ||
| if (line.index === undefined) { | ||
| line.index = index; | ||
| } |
|
@khmakoto how to port it? , now it is merged to 7.0 |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
@shivasai09 you should open a PR with the cherry-picked changes from this but to the master branch. |
|
@khmakoto is there any documentation on how to cherry-pick this branch and open a PR against the master, or do we have to create a other branch and manually add all the changes which are there in this branch to the freshly created branch and open a pr against the master.. how to proceed? |
|
@shivasai09 here's a good guide to git cherry pick. |
…soft#15551) * adding lines in the vertical stacked bar chart * Change files * fix build errors * fix build erros * when only the line is highlighted we should show callout to that * fix build issues * making the callout sort according to the rects * updating snapshots Co-authored-by: v-sivsar <[email protected]>
…soft#15551) * adding lines in the vertical stacked bar chart * Change files * fix build errors * fix build erros * when only the line is highlighted we should show callout to that * fix build issues * making the callout sort according to the rects * updating snapshots Co-authored-by: v-sivsar <[email protected]>
… (#16639) * adding lines in the vertical stacked bar chart * Change files * fix build errors * fix build erros * when only the line is highlighted we should show callout to that * fix build issues * making the callout sort according to the rects * updating snapshots Co-authored-by: v-sivsar <[email protected]> Co-authored-by: v-sivsar <[email protected]>
ecraig12345
removed
the
needs cherry-pick
Pull request checklist
$ yarn changeDescription of changes
added the new feature which is complex combo chart.
nothing but adding lines to the vertical stacked bar chart
hosted at
http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/15551/merge/charting/dist/index.html#/examples/VerticalStackedBarChart
Focus areas to test
vertical stacked bar chart