Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charting: Adding HorizontalBarChart tests #15706

Merged
merged 2 commits into from
Oct 27, 2020

Conversation

khmakoto
Copy link
Member

Pull request checklist

Description of changes

Cherry-pick of #15579.

Original PR description:

Added snapshot and basic unit test cases to the Horizontal bar chart.

Note: No actual snapshot differences either in original PR nor in here.

Focus areas to test

Horizontal bar chart

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f471438:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 809 810 5000
BaseButtonCompat mount 906 867 5000
Breadcrumb mount 157836 157357 5000
Checkbox mount 1472 1474 5000
CheckboxBase mount 1244 1225 5000
ChoiceGroup mount 4666 4635 5000
ComboBox mount 928 990 1000
CommandBar mount 21638 21846 1000
ContextualMenu mount 6091 6007 1000
DefaultButtonCompat mount 1106 1111 5000
DetailsRow mount 3583 3637 5000
DetailsRowFast mount 3535 3573 5000
DetailsRowNoStyles mount 3455 3440 5000
Dialog mount 1552 1461 1000
DocumentCardTitle mount 1791 1817 1000
Dropdown mount 3353 3408 5000
FocusTrapZone mount 1850 1726 5000
FocusZone mount 1767 1800 5000
IconButtonCompat mount 1709 1713 5000
Label mount 348 321 5000
Layer mount 1768 1802 5000
Link mount 433 470 5000
MenuButtonCompat mount 1513 1480 5000
MessageBar mount 2003 2100 5000
Nav mount 3269 3131 1000
OverflowSet mount 1027 1025 5000
Panel mount 1425 1429 1000
Persona mount 858 841 1000
Pivot mount 1346 1395 1000
PrimaryButtonCompat mount 1279 1271 5000
Rating mount 7225 7337 5000
SearchBox mount 1316 1270 5000
Shimmer mount 2411 2473 5000
Slider mount 1897 1846 5000
SpinButton mount 4872 4954 5000
Spinner mount 434 396 5000
SplitButtonCompat mount 3115 3135 5000
Stack mount 507 499 5000
StackWithIntrinsicChildren mount 1587 1475 5000
StackWithTextChildren mount 4541 4681 5000
SwatchColorPicker mount 10085 10039 5000
TagPicker mount 2732 2727 5000
TeachingBubble mount 11364 11293 5000
Text mount 440 419 5000
TextField mount 1332 1352 5000
ThemeProvider mount 1971 1925 5000
ThemeProvider virtual-rerender 678 648 5000
Toggle mount 784 798 5000
button mount 534 538 5000
buttonNative mount 120 101 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.45 0.49 0.92:1 2000 907
🦄 Button.Fluent 0.11 0.22 0.5:1 5000 568
🔧 Checkbox.Fluent 0.66 0.32 2.06:1 1000 658
🎯 Dialog.Fluent 0.16 0.22 0.73:1 5000 790
🔧 Dropdown.Fluent 2.93 0.4 7.33:1 1000 2934
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 736
🦄 Image.Fluent 0.08 0.13 0.62:1 5000 393
🔧 Slider.Fluent 1.63 0.44 3.7:1 1000 1625
🔧 Text.Fluent 0.07 0.03 2.33:1 5000 368
🦄 Tooltip.Fluent 0.12 0.89 0.13:1 5000 583

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
CardMinimalPerf.default 636 548 1.16:1
TreeWith60ListItems.default 232 207 1.12:1
RefMinimalPerf.default 264 237 1.11:1
HeaderMinimalPerf.default 403 373 1.08:1
ListNestedPerf.default 612 565 1.08:1
CarouselMinimalPerf.default 479 452 1.06:1
PortalMinimalPerf.default 177 167 1.06:1
LabelMinimalPerf.default 443 423 1.05:1
PopupMinimalPerf.default 732 694 1.05:1
ReactionMinimalPerf.default 433 412 1.05:1
SegmentMinimalPerf.default 385 366 1.05:1
TooltipMinimalPerf.default 855 817 1.05:1
ChatDuplicateMessagesPerf.default 426 412 1.03:1
ChatWithPopoverPerf.default 483 468 1.03:1
DropdownMinimalPerf.default 2988 2890 1.03:1
FlexMinimalPerf.default 317 309 1.03:1
ListCommonPerf.default 655 637 1.03:1
Checkbox.Fluent 658 637 1.03:1
Image.Fluent 393 383 1.03:1
AlertMinimalPerf.default 300 295 1.02:1
ButtonMinimalPerf.default 181 178 1.02:1
EmbedMinimalPerf.default 1956 1915 1.02:1
GridMinimalPerf.default 366 360 1.02:1
ListMinimalPerf.default 506 498 1.02:1
SplitButtonMinimalPerf.default 3782 3700 1.02:1
ButtonOverridesMissPerf.default 1709 1686 1.01:1
ChatMinimalPerf.default 634 630 1.01:1
CheckboxMinimalPerf.default 2882 2853 1.01:1
FormMinimalPerf.default 433 430 1.01:1
LoaderMinimalPerf.default 733 724 1.01:1
MenuButtonMinimalPerf.default 1580 1567 1.01:1
ProviderMergeThemesPerf.default 2104 2081 1.01:1
ProviderMinimalPerf.default 1047 1035 1.01:1
Avatar.Fluent 907 895 1.01:1
Dialog.Fluent 790 781 1.01:1
Slider.Fluent 1625 1614 1.01:1
DropdownManyItemsPerf.default 744 743 1:1
InputMinimalPerf.default 1342 1342 1:1
ListWith60ListItems.default 929 927 1:1
MenuMinimalPerf.default 872 869 1:1
RadioGroupMinimalPerf.default 460 459 1:1
TableManyItemsPerf.default 2189 2190 1:1
TextMinimalPerf.default 370 371 1:1
TextAreaMinimalPerf.default 491 492 1:1
ToolbarMinimalPerf.default 961 961 1:1
Icon.Fluent 736 733 1:1
ButtonSlotsPerf.default 597 601 0.99:1
ButtonUseCssPerf.default 824 832 0.99:1
DialogMinimalPerf.default 795 804 0.99:1
LayoutMinimalPerf.default 434 437 0.99:1
StatusMinimalPerf.default 712 716 0.99:1
IconMinimalPerf.default 682 687 0.99:1
CustomToolbarPrototype.default 3894 3934 0.99:1
Dropdown.Fluent 2934 2962 0.99:1
Text.Fluent 368 371 0.99:1
AttachmentSlotsPerf.default 1105 1123 0.98:1
BoxMinimalPerf.default 370 377 0.98:1
ButtonUseCssNestingPerf.default 1075 1101 0.98:1
DividerMinimalPerf.default 397 404 0.98:1
HeaderSlotsPerf.default 792 805 0.98:1
ImageMinimalPerf.default 388 394 0.98:1
ItemLayoutMinimalPerf.default 1270 1291 0.98:1
SliderMinimalPerf.default 1615 1653 0.98:1
AvatarMinimalPerf.default 469 484 0.97:1
VideoMinimalPerf.default 631 649 0.97:1
Tooltip.Fluent 583 600 0.97:1
AnimationMinimalPerf.default 400 416 0.96:1
SkeletonMinimalPerf.default 426 443 0.96:1
TreeMinimalPerf.default 905 941 0.96:1
Button.Fluent 568 598 0.95:1
AttachmentMinimalPerf.default 165 178 0.93:1
TableMinimalPerf.default 405 440 0.92:1
AccordionMinimalPerf.default 159 174 0.91:1

@size-auditor
Copy link

size-auditor bot commented Oct 27, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8fa8f369e59b28b5e0b4e175b7733e0b3bb2dc60 (build)

@ecraig12345 ecraig12345 merged commit ec27806 into microsoft:master Oct 27, 2020
@khmakoto khmakoto deleted the horizontalBarChartTests branch October 27, 2020 01:13
SethDonohue pushed a commit to SethDonohue/fluentui that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants