Styling: Add more semantic color slots #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzearing
reviewed
Jun 1, 2017
| inputFocusBorderAlt?: string; | ||
|
|
||
| // Menus, popups, etc | ||
| menuItemBackgroundHovered?: string; |
There was a problem hiding this comment.
I think each of these should have a simple comment explaining what scenario its used in. Otherwise the consumer has to solely rely on the name of the variable.
mikewheaton
changed the title
dzearing
approved these changes
Jun 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Adding some more semantic slots for colors to our styling module.
Focus areas to test
(optional)