-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-card: Scaffolding #19338
react-card: Scaffolding #19338
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 318ca3a:
|
📊 Bundle size report🤖 This report was generated against 1f31459994791525f065b24dabc0c55baacf2f8f |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 1f31459994791525f065b24dabc0c55baacf2f8f (build) |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 977 | 991 | 5000 | |
BaseButton | mount | 976 | 1019 | 5000 | |
Breadcrumb | mount | 2735 | 2730 | 1000 | |
ButtonNext | mount | 455 | 466 | 5000 | |
Checkbox | mount | 1707 | 1693 | 5000 | |
CheckboxBase | mount | 1390 | 1463 | 5000 | |
ChoiceGroup | mount | 5167 | 5041 | 5000 | |
ComboBox | mount | 1049 | 1036 | 1000 | |
CommandBar | mount | 10637 | 11038 | 1000 | |
ContextualMenu | mount | 6692 | 6503 | 1000 | |
DefaultButton | mount | 1197 | 1193 | 5000 | |
DetailsRow | mount | 3978 | 3968 | 5000 | |
DetailsRowFast | mount | 3963 | 3992 | 5000 | |
DetailsRowNoStyles | mount | 3695 | 3747 | 5000 | |
Dialog | mount | 2207 | 2233 | 1000 | |
DocumentCardTitle | mount | 159 | 163 | 1000 | |
Dropdown | mount | 3514 | 3562 | 5000 | |
FluentProviderNext | mount | 7164 | 7431 | 5000 | |
FocusTrapZone | mount | 1879 | 1927 | 5000 | |
FocusZone | mount | 1880 | 1904 | 5000 | |
IconButton | mount | 1851 | 1911 | 5000 | |
Label | mount | 356 | 343 | 5000 | |
Layer | mount | 1859 | 1899 | 5000 | |
Link | mount | 484 | 467 | 5000 | |
MakeStyles | mount | 1868 | 1824 | 50000 | |
MenuButton | mount | 1635 | 1582 | 5000 | |
MessageBar | mount | 2121 | 2147 | 5000 | |
Nav | mount | 3619 | 3668 | 1000 | |
OverflowSet | mount | 1175 | 1136 | 5000 | |
Panel | mount | 2284 | 2243 | 1000 | |
Persona | mount | 880 | 919 | 1000 | |
Pivot | mount | 1545 | 1556 | 1000 | |
PrimaryButton | mount | 1406 | 1422 | 5000 | |
Rating | mount | 8471 | 8522 | 5000 | |
SearchBox | mount | 1419 | 1432 | 5000 | |
Shimmer | mount | 2825 | 2788 | 5000 | |
Slider | mount | 2142 | 2068 | 5000 | |
SpinButton | mount | 5288 | 5410 | 5000 | |
Spinner | mount | 452 | 430 | 5000 | |
SplitButton | mount | 3427 | 3446 | 5000 | |
Stack | mount | 557 | 566 | 5000 | |
StackWithIntrinsicChildren | mount | 1790 | 1713 | 5000 | |
StackWithTextChildren | mount | 5270 | 5222 | 5000 | |
SwatchColorPicker | mount | 11139 | 11215 | 5000 | |
Tabs | mount | 1546 | 1512 | 1000 | |
TagPicker | mount | 2802 | 2827 | 5000 | |
TeachingBubble | mount | 12419 | 12577 | 5000 | |
Text | mount | 443 | 441 | 5000 | |
TextField | mount | 1488 | 1488 | 5000 | |
ThemeProvider | mount | 1222 | 1248 | 5000 | |
ThemeProvider | virtual-rerender | 619 | 616 | 5000 | |
Toggle | mount | 882 | 850 | 5000 | |
buttonNative | mount | 118 | 125 | 5000 |
Perf Analysis (@fluentui/react-northstar
)
Perf tests with no regressions
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
FlexMinimalPerf.default | 334 | 295 | 1.13:1 |
ButtonSlotsPerf.default | 634 | 580 | 1.09:1 |
PortalMinimalPerf.default | 181 | 169 | 1.07:1 |
AttachmentSlotsPerf.default | 1230 | 1162 | 1.06:1 |
ChatMinimalPerf.default | 732 | 693 | 1.06:1 |
CheckboxMinimalPerf.default | 3079 | 2917 | 1.06:1 |
HeaderSlotsPerf.default | 875 | 822 | 1.06:1 |
LabelMinimalPerf.default | 445 | 419 | 1.06:1 |
DropdownManyItemsPerf.default | 798 | 759 | 1.05:1 |
FormMinimalPerf.default | 456 | 435 | 1.05:1 |
HeaderMinimalPerf.default | 435 | 416 | 1.05:1 |
ImageMinimalPerf.default | 424 | 405 | 1.05:1 |
SegmentMinimalPerf.default | 393 | 374 | 1.05:1 |
TextAreaMinimalPerf.default | 589 | 562 | 1.05:1 |
AttachmentMinimalPerf.default | 191 | 183 | 1.04:1 |
RadioGroupMinimalPerf.default | 500 | 482 | 1.04:1 |
SkeletonMinimalPerf.default | 394 | 379 | 1.04:1 |
TreeMinimalPerf.default | 895 | 861 | 1.04:1 |
ButtonMinimalPerf.default | 190 | 184 | 1.03:1 |
CarouselMinimalPerf.default | 510 | 495 | 1.03:1 |
ChatDuplicateMessagesPerf.default | 327 | 317 | 1.03:1 |
ListMinimalPerf.default | 573 | 555 | 1.03:1 |
MenuMinimalPerf.default | 948 | 924 | 1.03:1 |
SplitButtonMinimalPerf.default | 4344 | 4232 | 1.03:1 |
AccordionMinimalPerf.default | 154 | 151 | 1.02:1 |
AnimationMinimalPerf.default | 464 | 456 | 1.02:1 |
PopupMinimalPerf.default | 618 | 603 | 1.02:1 |
RefMinimalPerf.default | 244 | 240 | 1.02:1 |
StatusMinimalPerf.default | 769 | 752 | 1.02:1 |
ButtonOverridesMissPerf.default | 1867 | 1843 | 1.01:1 |
DialogMinimalPerf.default | 846 | 838 | 1.01:1 |
DividerMinimalPerf.default | 413 | 409 | 1.01:1 |
DropdownMinimalPerf.default | 3364 | 3329 | 1.01:1 |
ListNestedPerf.default | 615 | 606 | 1.01:1 |
ListWith60ListItems.default | 708 | 704 | 1.01:1 |
MenuButtonMinimalPerf.default | 1803 | 1792 | 1.01:1 |
ProviderMinimalPerf.default | 1091 | 1077 | 1.01:1 |
CustomToolbarPrototype.default | 4212 | 4188 | 1.01:1 |
TooltipMinimalPerf.default | 1133 | 1126 | 1.01:1 |
VideoMinimalPerf.default | 712 | 706 | 1.01:1 |
CardMinimalPerf.default | 615 | 612 | 1:1 |
ChatWithPopoverPerf.default | 417 | 416 | 1:1 |
EmbedMinimalPerf.default | 4423 | 4440 | 1:1 |
InputMinimalPerf.default | 1336 | 1339 | 1:1 |
ListCommonPerf.default | 704 | 707 | 1:1 |
TableManyItemsPerf.default | 2165 | 2158 | 1:1 |
ToolbarMinimalPerf.default | 1047 | 1042 | 1:1 |
GridMinimalPerf.default | 372 | 376 | 0.99:1 |
LayoutMinimalPerf.default | 412 | 417 | 0.99:1 |
LoaderMinimalPerf.default | 737 | 746 | 0.99:1 |
BoxMinimalPerf.default | 377 | 384 | 0.98:1 |
DatepickerMinimalPerf.default | 5858 | 5948 | 0.98:1 |
ItemLayoutMinimalPerf.default | 1329 | 1361 | 0.98:1 |
RosterPerf.default | 1286 | 1308 | 0.98:1 |
ReactionMinimalPerf.default | 408 | 418 | 0.98:1 |
SliderMinimalPerf.default | 1676 | 1710 | 0.98:1 |
TextMinimalPerf.default | 385 | 393 | 0.98:1 |
AvatarMinimalPerf.default | 210 | 216 | 0.97:1 |
AlertMinimalPerf.default | 299 | 313 | 0.96:1 |
ProviderMergeThemesPerf.default | 1676 | 1756 | 0.95:1 |
IconMinimalPerf.default | 720 | 760 | 0.95:1 |
TableMinimalPerf.default | 429 | 451 | 0.95:1 |
TreeWith60ListItems.default | 177 | 190 | 0.93:1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be done as part of this change or in another PR but you should also look into updating the CODEOWNERS file for instances of this package.
Pull request checklist
- Addresses an existing issue: Fixes #0000- Include a change request file using$ yarn change
Description of changes
Re-creation of the react-card.