Palette not optional #1951
Merged
Palette not optional #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christiango
commented
Jun 7, 2017
| @@ -115,7 +115,7 @@ export class ThemePage extends React.Component<any, any> { | |||
| private _onColorChanged(index: number, newColor: string) { | |||
| let { colors } = this.state; | |||
| let color = colors[index]; | |||
| let theme: ITheme = {}; | |||
| let theme: Partial<IPalette> = {}; | |||
There was a problem hiding this comment.
I believe there's a bug here. Either this is a palette (in which case the theme variable should be renames) or we are in correctly creating an object to pass to loadTheme. I assumed palette, so I changed the type, but would like confirmation.
There was a problem hiding this comment.
Huh, you're right. Can you rename this variable to pallete or something? Then you can just loadTheme({ pallete })
There was a problem hiding this comment.
Yeah, I left it that way to make sure we noticed. I'll update it
dzearing
approved these changes
Jun 7, 2017
|
Awesome catch, sorry about that. Didn't even know about |
…/office-ui-fabric-react into palette-not-optional
…/office-ui-fabric-react into palette-not-optional
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Some recent changes to the styling package made palette and font optional, which means you'll need to null check if if you re using the strict options in Typescript. In reality, those types should always be defined. Updating the APIs that allow overriding the theme to take a Partial to make things work without making props optional.
Focus areas to test
(optional)