New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes TextField flexbox layout (for IE). #1954

Merged

dzearing merged 3 commits into microsoft:master from martellaj:joem/fix-textfield-flex-values

Jun 8, 2017

Member

martellaj commented Jun 8, 2017 •

edited

Loading

Description of changes

Adds required length unit to flex-basis value.
- flex-basis technically requires a length unit (i.e. "px"). Chrome, FF, Edge seem to comprehend the value without the length unit, but IE does not. Explicitly adding a unit so it behaves as expected in IE.
Observe how TextBox behaves in IE. In other browsers, inner field group properly grows to width of the component.

martellaj added 2 commits

June 7, 2017 16:52


          Adds required "length unit" to flex-basis value.


          Adds change file.

b17250b

msftclas added the cla-already-signed label


          Create joem-fix-textfield-flex-values_2017-06-08-00-07.json

66b03b3

dzearing approved these changes

View reviewed changes

dzearing merged commit 9cb6385 into microsoft:master

microsoft locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet