Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(react-slider) - Implementing root as slot and simplified prop merging #19652

Merged
merged 6 commits into from
Sep 7, 2021
Merged

(react-slider) - Implementing root as slot and simplified prop merging #19652

merged 6 commits into from
Sep 7, 2021

Conversation

czearing
Copy link
Collaborator

@czearing czearing commented Sep 5, 2021

Pull request checklist

Description of changes

Implementing the simplified prop merging #18642 and root as slot #19068 approaches into the converged Slider component.

@czearing czearing requested a review from a team as a code owner September 5, 2021 18:50
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 5, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b69fc0d:

Sandbox Source
Fluent UI React Starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 5, 2021 •
edited
Loading

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-slider
Slider		 30.693 kB
9.801 kB		 30.481 kB
9.681 kB		 212 B
120 B

🤖 This report was generated against 4c0cc9c87c507c215d5843274b75addc6f10eeba

@size-auditor
Copy link

size-auditor bot commented Sep 5, 2021 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4c0cc9c87c507c215d5843274b75addc6f10eeba (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 5, 2021 •
edited
Loading

Perf Analysis (@fluentui/react)

Scenario Render type Master Ticks PR Ticks Iterations Status
Panel mount 2129 1441 1000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 964 995 5000
BaseButton mount 1014 1009 5000
Breadcrumb mount 2651 2720 1000
ButtonNext mount 454 470 5000
Checkbox mount 1665 1683 5000
CheckboxBase mount 1382 1552 5000
ChoiceGroup mount 5152 5094 5000
ComboBox mount 1091 1052 1000
CommandBar mount 10843 10625 1000
ContextualMenu mount 6428 6600 1000
DefaultButton mount 1306 1289 5000
DetailsRow mount 3998 4253 5000
DetailsRowFast mount 3933 4011 5000
DetailsRowNoStyles mount 3846 3771 5000
Dialog mount 2247 2295 1000
DocumentCardTitle mount 160 170 1000
Dropdown mount 3461 3538 5000
FluentProviderNext mount 7131 7173 5000
FluentProviderWithTheme mount 370 379 10
FluentProviderWithTheme virtual-rerender 90 89 10
FluentProviderWithTheme virtual-rerender-with-unmount 487 472 10
FocusTrapZone mount 1869 1836 5000
FocusZone mount 1825 1840 5000
IconButton mount 1899 1891 5000
Label mount 352 361 5000
Layer mount 1986 1889 5000
Link mount 506 508 5000
MakeStyles mount 1884 1910 50000
MenuButton mount 1654 1620 5000
MessageBar mount 2102 2090 5000
Nav mount 3491 3417 1000
OverflowSet mount 1141 1187 5000
Panel mount 2129 1441 1000 Possible regression
Persona mount 878 891 1000
Pivot mount 1526 1532 1000
PrimaryButton mount 1410 1417 5000
Rating mount 8406 8476 5000
SearchBox mount 1500 1482 5000
Shimmer mount 2860 2864 5000
Slider mount 2060 2111 5000
SpinButton mount 5404 5314 5000
Spinner mount 431 428 5000
SplitButton mount 3509 3398 5000
Stack mount 574 574 5000
StackWithIntrinsicChildren mount 1711 1707 5000
StackWithTextChildren mount 5049 5185 5000
SwatchColorPicker mount 11286 11140 5000
Tabs mount 1691 1555 1000
TagPicker mount 2798 2763 5000
TeachingBubble mount 12593 12483 5000
Text mount 450 451 5000
TextField mount 1483 1525 5000
ThemeProvider mount 1232 1240 5000
ThemeProvider virtual-rerender 624 609 5000
ThemeProvider virtual-rerender-with-unmount 2056 2128 5000
Toggle mount 868 830 5000
buttonNative mount 113 123 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 172 152 1.13:1
PortalMinimalPerf.default 198 178 1.11:1
VideoMinimalPerf.default 723 650 1.11:1
AvatarMinimalPerf.default 227 208 1.09:1
ImageMinimalPerf.default 433 396 1.09:1
RefMinimalPerf.default 260 239 1.09:1
DropdownManyItemsPerf.default 795 736 1.08:1
ChatDuplicateMessagesPerf.default 331 308 1.07:1
GridMinimalPerf.default 398 373 1.07:1
TableMinimalPerf.default 453 425 1.07:1
FormMinimalPerf.default 477 449 1.06:1
SkeletonMinimalPerf.default 438 415 1.06:1
IconMinimalPerf.default 719 680 1.06:1
AlertMinimalPerf.default 304 289 1.05:1
AttachmentMinimalPerf.default 182 174 1.05:1
ButtonOverridesMissPerf.default 1867 1782 1.05:1
StatusMinimalPerf.default 786 746 1.05:1
DatepickerMinimalPerf.default 5988 5743 1.04:1
DividerMinimalPerf.default 405 388 1.04:1
ItemLayoutMinimalPerf.default 1415 1356 1.04:1
ListMinimalPerf.default 575 555 1.04:1
AnimationMinimalPerf.default 444 432 1.03:1
AttachmentSlotsPerf.default 1161 1129 1.03:1
BoxMinimalPerf.default 400 387 1.03:1
CardMinimalPerf.default 609 589 1.03:1
ListNestedPerf.default 598 578 1.03:1
ListWith60ListItems.default 702 684 1.03:1
SliderMinimalPerf.default 1710 1668 1.03:1
TooltipMinimalPerf.default 1130 1093 1.03:1
ChatMinimalPerf.default 731 715 1.02:1
DialogMinimalPerf.default 818 800 1.02:1
FlexMinimalPerf.default 311 305 1.02:1
LayoutMinimalPerf.default 404 395 1.02:1
ListCommonPerf.default 703 689 1.02:1
LoaderMinimalPerf.default 721 708 1.02:1
ReactionMinimalPerf.default 422 415 1.02:1
ToolbarMinimalPerf.default 1018 997 1.02:1
TreeWith60ListItems.default 187 184 1.02:1
ButtonSlotsPerf.default 641 632 1.01:1
CarouselMinimalPerf.default 491 487 1.01:1
HeaderSlotsPerf.default 890 880 1.01:1
InputMinimalPerf.default 1361 1345 1.01:1
MenuMinimalPerf.default 908 900 1.01:1
MenuButtonMinimalPerf.default 1770 1754 1.01:1
SegmentMinimalPerf.default 384 380 1.01:1
TableManyItemsPerf.default 2065 2050 1.01:1
TextAreaMinimalPerf.default 561 558 1.01:1
ButtonMinimalPerf.default 187 187 1:1
CheckboxMinimalPerf.default 2977 2977 1:1
EmbedMinimalPerf.default 4528 4534 1:1
ProviderMergeThemesPerf.default 1714 1712 1:1
LabelMinimalPerf.default 435 439 0.99:1
RosterPerf.default 1293 1304 0.99:1
PopupMinimalPerf.default 608 613 0.99:1
SplitButtonMinimalPerf.default 4617 4661 0.99:1
TreeMinimalPerf.default 854 866 0.99:1
DropdownMinimalPerf.default 3237 3305 0.98:1
ProviderMinimalPerf.default 1045 1070 0.98:1
RadioGroupMinimalPerf.default 483 491 0.98:1
CustomToolbarPrototype.default 4029 4133 0.97:1
TextMinimalPerf.default 366 382 0.96:1
ChatWithPopoverPerf.default 396 421 0.94:1
HeaderMinimalPerf.default 379 407 0.93:1

@czearing
Merge branch 'master' of https://github.com/microsoft/fluentui into f…
b4997f6 
…eat/slider-root-slot
@czearing
Merge branch 'master' of https://github.com/microsoft/fluentui into f…
b69fc0d 
…eat/slider-root-as-slot

# Conflicts:
#	packages/react-slider/src/common/isConformant.ts
#	packages/react-slider/src/components/Slider/Slider.types.ts
#	packages/react-slider/src/components/Slider/useSlider.ts
#	packages/react-slider/src/components/Slider/useSliderState.tsx
#	packages/react-slider/src/components/Slider/useSliderStyles.ts
@czearing czearing merged commit 1d5a819 into microsoft:master Sep 7, 2021
@czearing czearing mentioned this pull request Sep 9, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khmakoto khmakoto khmakoto approved these changes

@layershifter layershifter layershifter approved these changes

@bsunderhus bsunderhus Awaiting requested review from bsunderhus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@czearing @fabricteam @khmakoto @layershifter