Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-aria: mergeARIADisabled #19765

Merged
merged 5 commits into from
Sep 13, 2021

Conversation

bsunderhus
Copy link
Contributor

Pull request checklist

  • Include a change request file using $ yarn change

Description of changes

Generalizes mergeARIADisabled to be used in future hooks

@bsunderhus bsunderhus requested a review from a team September 13, 2021 10:57
@bsunderhus bsunderhus self-assigned this Sep 13, 2021
@fabricteam
Copy link
Collaborator

fabricteam commented Sep 13, 2021

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-accordion
Accordion (including children components)
55.26 kB
17.397 kB
55.248 kB
17.403 kB
12 B
-6 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
164.267 kB
46.831 kB
164.255 kB
46.836 kB
12 B
-5 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: FluentProvider & webLightTheme
35.75 kB
11.392 kB
🤖 This report was generated against 5fc24a72edaced0e1adc541afec83b6c50899731

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 13, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 88e3446:

Sandbox Source
Fluent UI React Starter Configuration

@size-auditor
Copy link

size-auditor bot commented Sep 13, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 5fc24a72edaced0e1adc541afec83b6c50899731 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 13, 2021

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 956 936 5000
BaseButton mount 987 997 5000
Breadcrumb mount 2787 2642 1000
ButtonNext mount 463 480 5000
Checkbox mount 1623 1671 5000
CheckboxBase mount 1427 1435 5000
ChoiceGroup mount 5239 5194 5000
ComboBox mount 1039 1027 1000
CommandBar mount 10841 10407 1000
ContextualMenu mount 6929 6748 1000
DefaultButton mount 1250 1236 5000
DetailsRow mount 4038 4200 5000
DetailsRowFast mount 4000 3941 5000
DetailsRowNoStyles mount 3761 3843 5000
Dialog mount 2578 2595 1000
DocumentCardTitle mount 148 172 1000
Dropdown mount 3469 3494 5000
FluentProviderNext mount 7247 7281 5000
FluentProviderWithTheme mount 377 391 10
FluentProviderWithTheme virtual-rerender 108 110 10
FluentProviderWithTheme virtual-rerender-with-unmount 531 481 10
FocusTrapZone mount 1738 1908 5000
FocusZone mount 1916 1938 5000
IconButton mount 2121 1907 5000
Label mount 347 359 5000
Layer mount 3126 3087 5000
Link mount 486 491 5000
MakeStyles mount 1777 1825 50000
MenuButton mount 1593 1613 5000
MessageBar mount 2073 2068 5000
Nav mount 3513 3474 1000
OverflowSet mount 1255 1160 5000
Panel mount 2413 2473 1000
Persona mount 873 882 1000
Pivot mount 1530 1530 1000
PrimaryButton mount 1394 1403 5000
Rating mount 8531 8348 5000
SearchBox mount 1465 1425 5000
Shimmer mount 2759 2723 5000
Slider mount 2086 2084 5000
SpinButton mount 5443 5383 5000
Spinner mount 424 439 5000
SplitButton mount 3356 3347 5000
Stack mount 547 592 5000
StackWithIntrinsicChildren mount 1692 1660 5000
StackWithTextChildren mount 5234 5178 5000
SwatchColorPicker mount 11228 11400 5000
Tabs mount 1512 1497 1000
TagPicker mount 2931 2798 5000
TeachingBubble mount 14035 14023 5000
Text mount 466 461 5000
TextField mount 1556 1555 5000
ThemeProvider mount 1288 1258 5000
ThemeProvider virtual-rerender 626 610 5000
ThemeProvider virtual-rerender-with-unmount 2086 2069 5000
Toggle mount 900 904 5000
buttonNative mount 125 106 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AvatarMinimalPerf.default 235 210 1.12:1
TreeWith60ListItems.default 191 172 1.11:1
LoaderMinimalPerf.default 791 734 1.08:1
ButtonMinimalPerf.default 197 184 1.07:1
AnimationMinimalPerf.default 443 417 1.06:1
AttachmentMinimalPerf.default 182 172 1.06:1
CardMinimalPerf.default 628 599 1.05:1
ListCommonPerf.default 706 675 1.05:1
AttachmentSlotsPerf.default 1154 1109 1.04:1
BoxMinimalPerf.default 397 381 1.04:1
DropdownManyItemsPerf.default 761 734 1.04:1
FlexMinimalPerf.default 315 303 1.04:1
GridMinimalPerf.default 373 357 1.04:1
ImageMinimalPerf.default 428 412 1.04:1
ProviderMinimalPerf.default 1111 1069 1.04:1
TooltipMinimalPerf.default 1119 1073 1.04:1
AlertMinimalPerf.default 305 296 1.03:1
ButtonSlotsPerf.default 603 587 1.03:1
ChatMinimalPerf.default 744 724 1.03:1
CheckboxMinimalPerf.default 2955 2864 1.03:1
EmbedMinimalPerf.default 4520 4372 1.03:1
LayoutMinimalPerf.default 403 392 1.03:1
ListMinimalPerf.default 564 550 1.03:1
ListNestedPerf.default 604 585 1.03:1
MenuButtonMinimalPerf.default 1853 1806 1.03:1
PortalMinimalPerf.default 181 175 1.03:1
RadioGroupMinimalPerf.default 493 479 1.03:1
TextMinimalPerf.default 408 397 1.03:1
ToolbarMinimalPerf.default 1037 1005 1.03:1
CarouselMinimalPerf.default 518 507 1.02:1
DividerMinimalPerf.default 412 404 1.02:1
SegmentMinimalPerf.default 386 378 1.02:1
TextAreaMinimalPerf.default 601 592 1.02:1
DialogMinimalPerf.default 816 811 1.01:1
HeaderMinimalPerf.default 393 389 1.01:1
ItemLayoutMinimalPerf.default 1325 1316 1.01:1
ReactionMinimalPerf.default 413 407 1.01:1
SkeletonMinimalPerf.default 389 386 1.01:1
SliderMinimalPerf.default 1653 1638 1.01:1
StatusMinimalPerf.default 746 736 1.01:1
CustomToolbarPrototype.default 4178 4127 1.01:1
TreeMinimalPerf.default 878 868 1.01:1
HeaderSlotsPerf.default 829 825 1:1
ProviderMergeThemesPerf.default 1724 1726 1:1
RefMinimalPerf.default 237 236 1:1
SplitButtonMinimalPerf.default 4482 4467 1:1
DropdownMinimalPerf.default 3198 3218 0.99:1
LabelMinimalPerf.default 406 409 0.99:1
PopupMinimalPerf.default 627 636 0.99:1
TableManyItemsPerf.default 2144 2164 0.99:1
VideoMinimalPerf.default 718 727 0.99:1
ButtonOverridesMissPerf.default 1819 1863 0.98:1
DatepickerMinimalPerf.default 5668 5766 0.98:1
IconMinimalPerf.default 709 720 0.98:1
AccordionMinimalPerf.default 167 172 0.97:1
FormMinimalPerf.default 446 462 0.97:1
InputMinimalPerf.default 1304 1348 0.97:1
MenuMinimalPerf.default 906 935 0.97:1
TableMinimalPerf.default 469 483 0.97:1
ChatDuplicateMessagesPerf.default 307 320 0.96:1
ChatWithPopoverPerf.default 385 400 0.96:1
ListWith60ListItems.default 682 709 0.96:1
RosterPerf.default 1279 1330 0.96:1

@bsunderhus bsunderhus merged commit 5e2d778 into microsoft:master Sep 13, 2021
@bsunderhus bsunderhus deleted the react-aria-mergeARIADisabled branch September 13, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants