Tooltip - support custom mountNode #22134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahgodbolt
requested review from
a team,
behowell and
khmakoto
as code owners
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7f2f654:
|
📊 Bundle size report
Unchanged fixtures
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 828 | 788 | 5000 | |
| Button | mount | 521 | 554 | 5000 | |
| FluentProvider | mount | 1797 | 1873 | 5000 | |
| FluentProviderWithTheme | mount | 252 | 246 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 210 | 230 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 277 | 315 | 10 | |
| MakeStyles | mount | 1513 | 1547 | 50000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: dc052f73217d64dc7724710483fc6bc020620b77 (build) |
packages/react-tooltip/src/stories/TooltipCustomMount.stories.tsx
Outdated
Show resolved
Hide resolved
khmakoto
approved these changes
Mar 19, 2022
packages/react-tooltip/src/stories/TooltipCustomMount.stories.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Makoto Morimoto <[email protected]>
change/@fluentui-react-tooltip-79df9179-1dd1-4817-9d7b-623d2a2fe436.json
Outdated
Show resolved
Hide resolved
packages/react-tooltip/src/stories/TooltipCustomMount.stories.tsx
Outdated
Show resolved
Hide resolved
layershifter
approved these changes
Mar 23, 2022
…fe436.json Co-authored-by: Oleksandr Fediashov <[email protected]>
Co-authored-by: Oleksandr Fediashov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tooltip is being rendered inside of a Portal, but the mountNode prop is not accessible to be passed through like you can in Popover. A custom mountNode is required for tooltips rendered inside of full screen divs (like a video player).
Added the
mountNodeprop along with a demo of how to use the prop.