Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-card): align stories with the rest of the library #23082

Merged
merged 1 commit into from
May 20, 2022
Merged

chore(react-card): align stories with the rest of the library #23082

merged 1 commit into from
May 20, 2022

Conversation

andrefcdias
Copy link
Contributor

New Behavior

  • No longer wrapping theme on appearance stories

Related Issue(s)

#19336

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-card
Card - All
59.002 kB
16.923 kB
react-card
Card
54.287 kB
15.672 kB
react-card
CardFooter
7.793 kB
3.327 kB
react-card
CardHeader
9.363 kB
3.841 kB
react-card
CardPreview
7.765 kB
3.35 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
179.667 kB
50.151 kB
react-components
react-components: FluentProvider & webLightTheme
34.078 kB
11.098 kB
🤖 This report was generated against 60804cec07a495b8a5d1fc66338bf0443b212144

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1d1a27c:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented May 19, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 60804cec07a495b8a5d1fc66338bf0443b212144 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender-with-unmount 274 289 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 917 895 5000
Button mount 585 577 5000
FluentProvider mount 1911 2198 5000
FluentProviderWithTheme mount 269 230 10
FluentProviderWithTheme virtual-rerender 223 222 10
FluentProviderWithTheme virtual-rerender-with-unmount 274 289 10 Possible regression
MakeStyles mount 1708 1765 50000

@andrefcdias andrefcdias marked this pull request as ready for review May 20, 2022 12:18
@andrefcdias andrefcdias requested a review from a team as a code owner May 20, 2022 12:18
@andrefcdias andrefcdias requested a review from Hotell May 20, 2022 12:18
@andrefcdias andrefcdias merged commit 1c7023c into microsoft:master May 20, 2022
@andrefcdias andrefcdias deleted the card-refactor-appearance-stories branch May 20, 2022 15:28
marwan38 pushed a commit to marwan38/fluentui that referenced this pull request Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants