Easy choice group option props

[GeoffCoxMSFT]

Issue

ODSP upgrade to v8 requires hundreds of updates to render callbacks in ChoiceGroup because of the creation of the IChoiceGroupOptionProps. This extends IChoiceGroupOption. This change allows existing callbacks that take IChoiceGroupOption to continue to work without having to manually update the typing.

Changes

• Added IChoiceGroupOption as a parameter type in render callbacks for ChoiceGroup.

[GeoffCoxMSFT]

@behowell - Appreciate if you can take a look and verify that the change will be backwards compatible.

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 82f9970:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

[size-auditor]

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 450ae785aef3914dc55584159dca585ee5f2561e (build)

[fabricteam]

📊 Bundle size report

_{🤖 This report was generated against 450ae785aef3914dc55584159dca585ee5f2561e}

[fabricteam]

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
BaseButton	mount	781	799	5000
Breadcrumb	mount	2416	2428	1000
Checkbox	mount	2287	2249	5000
CheckboxBase	mount	1964	2006	5000
ChoiceGroup	mount	4093	4081	5000
ComboBox	mount	854	913	1000
CommandBar	mount	9157	9137	1000
ContextualMenu	mount	10460	10530	1000
DefaultButton	mount	1001	984	5000
DetailsRow	mount	3342	3314	5000
DetailsRowFast	mount	3290	3356	5000
DetailsRowNoStyles	mount	3133	3184	5000
Dialog	mount	2448	2448	1000
DocumentCardTitle	mount	152	145	1000
Dropdown	mount	2875	2885	5000
FocusTrapZone	mount	1618	1608	5000
FocusZone	mount	1607	1565	5000
IconButton	mount	1510	1571	5000
Label	mount	312	302	5000
Layer	mount	2703	2730	5000
Link	mount	396	418	5000
MenuButton	mount	1277	1290	5000
MessageBar	mount	1887	1868	5000
Nav	mount	2862	2833	1000
OverflowSet	mount	961	945	5000
Panel	mount	1903	1895	1000
Persona	mount	862	875	1000
Pivot	mount	1266	1251	1000
PrimaryButton	mount	1155	1149	5000
Rating	mount	6669	6715	5000
SearchBox	mount	1134	1140	5000
Shimmer	mount	2164	2159	5000
Slider	mount	1674	1679	5000
SpinButton	mount	4412	4599	5000
Spinner	mount	382	379	5000
SplitButton	mount	2791	2734	5000
Stack	mount	451	447	5000
StackWithIntrinsicChildren	mount	1979	1963	5000
StackWithTextChildren	mount	4532	4487	5000
SwatchColorPicker	mount	10077	10084	5000
TagPicker	mount	2370	2344	5000
TeachingBubble	mount	88092	86115	5000
Text	mount	381	367	5000
TextField	mount	1198	1214	5000
ThemeProvider	mount	1061	1060	5000
ThemeProvider	virtual-rerender	590	588	5000
ThemeProvider	virtual-rerender-with-unmount	1540	1558	5000
Toggle	mount	696	694	5000
buttonNative	mount	120	117	5000

[DarkKilauea]

Hey folks,

This change does break backwards compatibility. The change limits usage to only those properties that both IChoiceGroupOption and IChoiceGroupOptionProps share, which is quite limiting. This unfortunately has broken one of our projects inside MS and will require opting out of type checking in order to work around.

Not sure how you want this reported (heck, not sure if anyone will ever see this), but figured you should know and consider a revert.

Thanks.

[spmonahan]

@DarkKilauea , could you file a bug report please? This will ensure the issue is triaged.

[GeoffCoxMSFT]

Hey folks,

This change does break backwards compatibility. The change limits usage to only those properties that both IChoiceGroupOption and IChoiceGroupOptionProps share, which is quite limiting. This unfortunately has broken one of our projects inside MS and will require opting out of type checking in order to work around.

Not sure how you want this reported (heck, not sure if anyone will ever see this), but figured you should know and consider a revert.

Thanks.

@DarkKilauea I updated the signature in this PR to try and resolve the breaking change: #25475