Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added exports for ContextualMenu getItemStyles and getItemClassNames to v8 #24484

Merged

Conversation

GeoffCoxMSFT
Copy link
Member

To better support removing deep imports in ODSP.

Changes

  • added top-level export of ContextualMenu getItemStyles as getContextualMenuItemStyles
  • added top-level export of ContextualMenu getItemClassNames as getContextualMenuItemClassNames

Issues

Updates #24454

To be cherry picked to 7.0 branch.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 23, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b04a718:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 23, 2022

📊 Bundle size report

🤖 This report was generated against f3104008db3243375c8e3ab0c152adacafab46d0

@GeoffCoxMSFT GeoffCoxMSFT enabled auto-merge (squash) August 23, 2022 20:02
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 23, 2022

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 770 752 5000
Breadcrumb mount 2427 2441 1000
Checkbox mount 2237 2190 5000
CheckboxBase mount 1941 1955 5000
ChoiceGroup mount 3986 3977 5000
ComboBox mount 829 842 1000
CommandBar mount 9205 9123 1000
ContextualMenu mount 10561 10626 1000
DefaultButton mount 970 961 5000
DetailsRow mount 3251 3324 5000
DetailsRowFast mount 3303 3288 5000
DetailsRowNoStyles mount 3112 3086 5000
Dialog mount 2731 2773 1000
DocumentCardTitle mount 146 152 1000
Dropdown mount 2843 2851 5000
FocusTrapZone mount 1586 1572 5000
FocusZone mount 1516 1594 5000
IconButton mount 1503 1527 5000
Label mount 304 313 5000
Layer mount 3936 3874 5000
Link mount 388 393 5000
MenuButton mount 1247 1247 5000
MessageBar mount 1798 1801 5000
Nav mount 2847 2894 1000
OverflowSet mount 1257 947 5000
Panel mount 2154 2145 1000
Persona mount 842 825 1000
Pivot mount 1268 1214 1000
PrimaryButton mount 1085 1110 5000
Rating mount 6700 6598 5000
SearchBox mount 1097 1094 5000
Shimmer mount 2972 3875 5000
Slider mount 1662 1683 5000
SpinButton mount 4429 4331 5000
Spinner mount 379 391 5000
SplitButton mount 2682 2702 5000
Stack mount 461 450 5000
StackWithIntrinsicChildren mount 1962 1908 5000
StackWithTextChildren mount 4369 4386 5000
SwatchColorPicker mount 10348 10115 5000
TagPicker mount 2277 2233 5000
TeachingBubble mount 86086 86811 5000
Text mount 357 363 5000
TextField mount 1197 1166 5000
ThemeProvider mount 1105 1105 5000
ThemeProvider virtual-rerender 645 656 5000
ThemeProvider virtual-rerender-with-unmount 1730 1747 5000
Toggle mount 694 716 5000
buttonNative mount 119 105 5000

@GeoffCoxMSFT GeoffCoxMSFT disabled auto-merge August 23, 2022 20:16
@size-auditor
Copy link

size-auditor bot commented Aug 23, 2022

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react fluentui-react-ContextualMenu 145.352 kB 145.456 kB ExceedsBaseline     104 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: f3104008db3243375c8e3ab0c152adacafab46d0 (build)

@GeoffCoxMSFT GeoffCoxMSFT merged commit 23a0768 into microsoft:master Aug 23, 2022
GeoffCoxMSFT added a commit to GeoffCoxMSFT/fluentui that referenced this pull request Aug 24, 2022
…to v8 (microsoft#24484)

* Added exports for ContextualMenu getItemStyles and getItemClassNames

* yarn change

* Fixed param comment

* Update API.md
GeoffCoxMSFT added a commit that referenced this pull request Aug 24, 2022
* Added exports for ContextualMenu getItemStyles and getItemClassNames to v8 (#24484)

* Added exports for ContextualMenu getItemStyles and getItemClassNames

* yarn change

* Fixed param comment

* Update API.md

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants