-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix(react-tooltip): stops propagation on Escape keydown #24810
bugfix(react-tooltip): stops propagation on Escape keydown #24810
Conversation
📊 Bundle size report
Unchanged fixtures
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c39d4d8:
|
Asset size changesUnable to find bundle size details for Baseline commit: b111ddd Possible causes
Recommendations
|
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 1343 | 1302 | 5000 | |
Button | mount | 958 | 956 | 5000 | |
FluentProvider | mount | 1562 | 1583 | 5000 | |
FluentProviderWithTheme | mount | 640 | 629 | 10 | |
FluentProviderWithTheme | virtual-rerender | 594 | 594 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 625 | 629 | 10 | |
MakeStyles | mount | 1890 | 1905 | 50000 | |
SpinButton | mount | 2492 | 2525 | 5000 |
43db6d5
to
bd37c00
Compare
bd37c00
to
c39d4d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this change!
Current Behavior
Currently pressing
Escape
key to dismiss aTooltip
, will propagate aEscape
keydown event that might trigger dismiss in more than just theTooltip
itself. see #24750New Behavior
Escape
keydown to ensure onlyTooltip
is dismissed.Tooltip
escape behaviour is the first thing to be executed.