Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export icon names input v8 #24957

Merged

Conversation

GeoffCoxMSFT
Copy link
Member

Changes

  • Added IconNamesImport from @fluentui/font-icons-mdl2

Issues

Updates #24393

@size-auditor
Copy link

size-auditor bot commented Sep 26, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 1dcb695eb7e57a1128156049e08729206cc790ae (build)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 374159d:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against 203e5dea1f8f63f209c09f34b1f1e5274fafd5ac

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 2563 1210 5000 Possible regression
Checkbox mount 2651 4340 5000 Possible regression
GroupedListV2 virtual-rerender-with-unmount 842 571 2 Possible regression
SplitButton mount 2951 3947 5000 Possible regression
StackWithIntrinsicChildren mount 2591 2225 5000 Possible regression
ThemeProvider virtual-rerender-with-unmount 2069 2620 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 2563 1210 5000 Possible regression
Breadcrumb mount 2957 2957 1000
Checkbox mount 2651 4340 5000 Possible regression
CheckboxBase mount 2335 2339 5000
ChoiceGroup mount 4406 5444 5000
ComboBox mount 1257 1256 1000
CommandBar mount 9685 9691 1000
ContextualMenu mount 12762 11479 1000
DefaultButton mount 1398 1389 5000
DetailsRow mount 3635 3620 5000
DetailsRowFast mount 3668 3588 5000
DetailsRowNoStyles mount 3506 3480 5000
Dialog mount 3079 3089 1000
DocumentCardTitle mount 588 578 1000
Dropdown mount 3250 3246 5000
FocusTrapZone mount 2021 2007 5000
FocusZone mount 1978 1940 5000
GroupedList mount 54544 61308 2
GroupedList virtual-rerender 25069 25358 2
GroupedList virtual-rerender-with-unmount 93466 93920 2
GroupedListV2 mount 571 560 2
GroupedListV2 virtual-rerender 527 518 2
GroupedListV2 virtual-rerender-with-unmount 842 571 2 Possible regression
IconButton mount 1900 1915 5000
Label mount 735 747 5000
Layer mount 4547 4211 5000
Link mount 830 841 5000
MenuButton mount 1700 1707 5000
MessageBar mount 2432 2323 5000
Nav mount 3719 3584 1000
OverflowSet mount 1304 1271 5000
Panel mount 2457 2534 1000
Persona mount 1282 1299 1000
Pivot mount 1645 2091 1000
PrimaryButton mount 1411 1521 5000
Rating mount 8224 6949 5000
SearchBox mount 1367 1448 5000
Shimmer mount 2859 2724 5000
Slider mount 2057 2078 5000
SpinButton mount 4626 4454 5000
Spinner mount 780 788 5000
SplitButton mount 2951 3947 5000 Possible regression
Stack mount 832 801 5000
StackWithIntrinsicChildren mount 2591 2225 5000 Possible regression
StackWithTextChildren mount 4611 4656 5000
SwatchColorPicker mount 10475 9973 5000
TagPicker mount 2728 2702 5000
TeachingBubble mount 89855 91655 5000
Text mount 763 750 5000
TextField mount 1544 1563 5000
ThemeProvider mount 1426 1501 5000
ThemeProvider virtual-rerender 1070 1041 5000
ThemeProvider virtual-rerender-with-unmount 2069 2620 5000 Possible regression
Toggle mount 1019 1087 5000
buttonNative mount 545 530 5000

@GeoffCoxMSFT GeoffCoxMSFT enabled auto-merge (squash) September 27, 2022 15:39
@GeoffCoxMSFT GeoffCoxMSFT requested a review from a team September 28, 2022 21:36
@GeoffCoxMSFT GeoffCoxMSFT merged commit 6112cd7 into microsoft:master Sep 30, 2022
GeoffCoxMSFT added a commit to GeoffCoxMSFT/fluentui that referenced this pull request Oct 3, 2022
* Added top-level export of IconNamesInput to match v7

* yarn change
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
* Added top-level export of IconNamesInput to match v7

* yarn change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants