Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-menu): migrate to new package structure #25015

Conversation

TristanWatanabe
Copy link
Member

@TristanWatanabe TristanWatanabe commented Sep 29, 2022

Changes:

Issue:

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 29, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
62.827 kB
17.599 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
189.299 kB
52.51 kB
react-components
react-components: FluentProvider & webLightTheme
33.446 kB
11.033 kB
react-menu
Menu (including children components)
116.63 kB
35.759 kB
react-menu
Menu (including selectable components)
119.699 kB
36.281 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
🤖 This report was generated against 7380b15b3c9997bad0e832fb17fade1b9db45aaf

@size-auditor
Copy link

size-auditor bot commented Sep 29, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 863058740bb2f3e82680db503268b3e937ddf86d (build)

@TristanWatanabe TristanWatanabe force-pushed the menu-migrate-to-new-package-structure branch from 3cca99c to 2ffc15e Compare September 29, 2022 17:02
@TristanWatanabe TristanWatanabe changed the title [TESTING DO NOT MERGE]: Menu migrate to new package structure chore(react-menu): migrate to new package structure Oct 12, 2022
@TristanWatanabe TristanWatanabe marked this pull request as ready for review October 12, 2022 20:32
@TristanWatanabe TristanWatanabe requested a review from a team as a code owner October 12, 2022 20:32
@TristanWatanabe TristanWatanabe merged commit 61915ce into microsoft:master Oct 14, 2022
@TristanWatanabe TristanWatanabe deleted the menu-migrate-to-new-package-structure branch October 14, 2022 15:11
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants