Add conformance and vr tests to react-progress #25105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spmonahan
reviewed
Oct 6, 2022
apps/vr-tests-react-components/src/stories/Progress.stories.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/Progress.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/Progress.test.tsx
Outdated
Show resolved
Hide resolved
📊 Bundle size report
Unchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2eaed63:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: c78ae4c551ef8dd8109fc339047cfdfd1c1b9948 (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1305 | 1290 | 5000 | |
| Button | mount | 971 | 965 | 5000 | |
| FluentProvider | mount | 1636 | 1614 | 5000 | |
| FluentProviderWithTheme | mount | 634 | 639 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 595 | 595 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 634 | 646 | 10 | |
| MakeStyles | mount | 1904 | 1917 | 50000 | |
| SpinButton | mount | 2540 | 2512 | 5000 |
behowell
approved these changes
Oct 7, 2022
packages/react-components/react-progress/src/components/Progress/Progress.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/Progress.test.tsx
Show resolved
Hide resolved
khmakoto
approved these changes
Oct 7, 2022
change/@fluentui-react-progress-0341ff0e-8632-492b-8459-66f2acc50ea6.json
Outdated
Show resolved
Hide resolved
…c50ea6.json Co-authored-by: Makoto Morimoto <[email protected]>
…c-react into react-progress-tests
sopranopillow
approved these changes
Oct 7, 2022
|
Approved the screener changes. I still can't figure out where the button changes are coming from, but I can't see anything in this PR that could cause them, so I've approved them as well. |
spmonahan
approved these changes
Oct 12, 2022
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
* Add conformance and vr tests to react-progress * Add Progress stories to vr tests * remove private tag in package.json * Update tests * change files * update package.json * fix * fix typo * Update SPEC.md with ProgressField info * update rtl styling and vr test * cleanup * Move aria props to root and update tests * Update change/@fluentui-react-progress-0341ff0e-8632-492b-8459-66f2acc50ea6.json Co-authored-by: Makoto Morimoto <[email protected]> * Add test for max prop * remove snapshot Co-authored-by: Makoto Morimoto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds conformance and vr tests for
Progress