fix: version-bump generator removes beachball disallowedChangeType config #25130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfig for nightly releases Fixes #25116
tudorpopams
approved these changes
Oct 7, 2022
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d59683655d4d2a3775df4a2b41a09504cddd72ad (build) |
Hotell
reviewed
Oct 7, 2022
|
|
||
| // nightly releases should bypass beachball disallowed changetypes | ||
| if (schema.bumpType === 'nightly' && packageJson.beachball?.disallowedChangeTypes) { | ||
| packageJson.beachball.disallowedChangeTypes = undefined; |
There was a problem hiding this comment.
lets get rid of it completely
Suggested change
| packageJson.beachball.disallowedChangeTypes = undefined; | |
| delete packageJson.beachball.disallowedChangeTypes |
Hotell
reviewed
Oct 7, 2022
| @@ -31,6 +31,9 @@ export interface PackageJson { | |||
| devDependencies?: Record<string, string>; | |||
| peerDependencies?: Record<string, string>; | |||
| exports?: Record<string, string | Partial<{ types: string; import: string; require: string }>>; | |||
| beachball?: { | |||
There was a problem hiding this comment.
suggestion: can we extract these tool specific to separate interface and extend PackageJson ? I mean "beachball" is definitely not a standard package.json property
Hotell
approved these changes
Oct 7, 2022
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9b5a40b:
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1280 | 1274 | 5000 | |
| Button | mount | 938 | 939 | 5000 | |
| FluentProvider | mount | 1489 | 1503 | 5000 | |
| FluentProviderWithTheme | mount | 584 | 589 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 538 | 553 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 575 | 579 | 10 | |
| MakeStyles | mount | 1936 | 1930 | 50000 | |
| SpinButton | mount | 2358 | 2313 | 5000 |
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| VideoMinimalPerf.default | 885 | 789 | 1.12:1 |
| AlertMinimalPerf.default | 305 | 275 | 1.11:1 |
| AccordionMinimalPerf.default | 170 | 158 | 1.08:1 |
| GridMinimalPerf.default | 374 | 347 | 1.08:1 |
| AttachmentSlotsPerf.default | 1243 | 1176 | 1.06:1 |
| ButtonMinimalPerf.default | 194 | 183 | 1.06:1 |
| CardMinimalPerf.default | 615 | 581 | 1.06:1 |
| DialogMinimalPerf.default | 863 | 813 | 1.06:1 |
| FlexMinimalPerf.default | 313 | 296 | 1.06:1 |
| AttachmentMinimalPerf.default | 176 | 167 | 1.05:1 |
| ChatWithPopoverPerf.default | 402 | 383 | 1.05:1 |
| ImageMinimalPerf.default | 438 | 417 | 1.05:1 |
| TreeWith60ListItems.default | 181 | 173 | 1.05:1 |
| AvatarMinimalPerf.default | 218 | 209 | 1.04:1 |
| BoxMinimalPerf.default | 376 | 363 | 1.04:1 |
| LayoutMinimalPerf.default | 393 | 377 | 1.04:1 |
| ToolbarMinimalPerf.default | 1034 | 996 | 1.04:1 |
| CarouselMinimalPerf.default | 502 | 486 | 1.03:1 |
| ChatDuplicateMessagesPerf.default | 286 | 278 | 1.03:1 |
| RadioGroupMinimalPerf.default | 496 | 482 | 1.03:1 |
| SkeletonMinimalPerf.default | 382 | 370 | 1.03:1 |
| ChatMinimalPerf.default | 784 | 769 | 1.02:1 |
| CheckboxMinimalPerf.default | 2282 | 2261 | 1.01:1 |
| LabelMinimalPerf.default | 410 | 405 | 1.01:1 |
| ListWith60ListItems.default | 674 | 665 | 1.01:1 |
| RosterPerf.default | 2373 | 2352 | 1.01:1 |
| ProviderMergeThemesPerf.default | 1291 | 1273 | 1.01:1 |
| TableMinimalPerf.default | 432 | 429 | 1.01:1 |
| DatepickerMinimalPerf.default | 6210 | 6186 | 1:1 |
| DropdownManyItemsPerf.default | 725 | 726 | 1:1 |
| DropdownMinimalPerf.default | 2820 | 2821 | 1:1 |
| HeaderMinimalPerf.default | 388 | 387 | 1:1 |
| MenuButtonMinimalPerf.default | 1848 | 1849 | 1:1 |
| PortalMinimalPerf.default | 166 | 166 | 1:1 |
| SliderMinimalPerf.default | 1715 | 1722 | 1:1 |
| TreeMinimalPerf.default | 859 | 857 | 1:1 |
| ButtonOverridesMissPerf.default | 1433 | 1443 | 0.99:1 |
| DividerMinimalPerf.default | 407 | 413 | 0.99:1 |
| EmbedMinimalPerf.default | 3988 | 4031 | 0.99:1 |
| HeaderSlotsPerf.default | 827 | 838 | 0.99:1 |
| LoaderMinimalPerf.default | 708 | 717 | 0.99:1 |
| SplitButtonMinimalPerf.default | 4780 | 4807 | 0.99:1 |
| StatusMinimalPerf.default | 755 | 762 | 0.99:1 |
| IconMinimalPerf.default | 700 | 709 | 0.99:1 |
| TableManyItemsPerf.default | 2083 | 2097 | 0.99:1 |
| TextMinimalPerf.default | 369 | 374 | 0.99:1 |
| CustomToolbarPrototype.default | 2769 | 2796 | 0.99:1 |
| ItemLayoutMinimalPerf.default | 1331 | 1364 | 0.98:1 |
| ListMinimalPerf.default | 555 | 567 | 0.98:1 |
| ListNestedPerf.default | 610 | 621 | 0.98:1 |
| MenuMinimalPerf.default | 902 | 917 | 0.98:1 |
| PopupMinimalPerf.default | 656 | 667 | 0.98:1 |
| AnimationMinimalPerf.default | 551 | 570 | 0.97:1 |
| InputMinimalPerf.default | 1191 | 1231 | 0.97:1 |
| ProviderMinimalPerf.default | 400 | 412 | 0.97:1 |
| ReactionMinimalPerf.default | 409 | 422 | 0.97:1 |
| SegmentMinimalPerf.default | 376 | 388 | 0.97:1 |
| FormMinimalPerf.default | 438 | 458 | 0.96:1 |
| ButtonSlotsPerf.default | 602 | 634 | 0.95:1 |
| ListCommonPerf.default | 698 | 731 | 0.95:1 |
| TextAreaMinimalPerf.default | 547 | 578 | 0.95:1 |
| RefMinimalPerf.default | 224 | 238 | 0.94:1 |
| TooltipMinimalPerf.default | 2489 | 2750 | 0.91:1 |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 1226 | 1224 | 5000 | |
| Breadcrumb | mount | 2998 | 2991 | 1000 | |
| Checkbox | mount | 2679 | 2663 | 5000 | |
| CheckboxBase | mount | 2396 | 2363 | 5000 | |
| ChoiceGroup | mount | 4294 | 4277 | 5000 | |
| ComboBox | mount | 1173 | 1189 | 1000 | |
| CommandBar | mount | 9735 | 9574 | 1000 | |
| ContextualMenu | mount | 12268 | 12393 | 1000 | |
| DefaultButton | mount | 1382 | 1372 | 5000 | |
| DetailsRow | mount | 3425 | 3434 | 5000 | |
| DetailsRowFast | mount | 3409 | 3391 | 5000 | |
| DetailsRowNoStyles | mount | 3252 | 3302 | 5000 | |
| Dialog | mount | 2986 | 2986 | 1000 | |
| DocumentCardTitle | mount | 584 | 584 | 1000 | |
| Dropdown | mount | 3180 | 3184 | 5000 | |
| FocusTrapZone | mount | 1961 | 1973 | 5000 | |
| FocusZone | mount | 1911 | 1940 | 5000 | |
| GroupedList | mount | 50795 | 56869 | 2 | |
| GroupedList | virtual-rerender | 23960 | 23953 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 85062 | 100982 | 2 | |
| GroupedListV2 | mount | 564 | 578 | 2 | |
| GroupedListV2 | virtual-rerender | 531 | 529 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 553 | 570 | 2 | |
| IconButton | mount | 1810 | 1785 | 5000 | |
| Label | mount | 772 | 766 | 5000 | |
| Layer | mount | 4160 | 4176 | 5000 | |
| Link | mount | 856 | 873 | 5000 | |
| MenuButton | mount | 1623 | 1645 | 5000 | |
| MessageBar | mount | 2295 | 2356 | 5000 | |
| Nav | mount | 3095 | 3090 | 1000 | |
| OverflowSet | mount | 1421 | 1427 | 5000 | |
| Panel | mount | 2505 | 2537 | 1000 | |
| Persona | mount | 1261 | 1260 | 1000 | |
| Pivot | mount | 1518 | 1534 | 1000 | |
| PrimaryButton | mount | 1504 | 1494 | 5000 | |
| Rating | mount | 7059 | 6970 | 5000 | |
| SearchBox | mount | 1499 | 1515 | 5000 | |
| Shimmer | mount | 2918 | 2920 | 5000 | |
| Slider | mount | 2141 | 2090 | 5000 | |
| SpinButton | mount | 4243 | 4290 | 5000 | |
| Spinner | mount | 850 | 836 | 5000 | |
| SplitButton | mount | 2831 | 2848 | 5000 | |
| Stack | mount | 902 | 899 | 5000 | |
| StackWithIntrinsicChildren | mount | 2276 | 2248 | 5000 | |
| StackWithTextChildren | mount | 4932 | 4942 | 5000 | |
| SwatchColorPicker | mount | 9562 | 9535 | 5000 | |
| TagPicker | mount | 2365 | 2377 | 5000 | |
| TeachingBubble | mount | 88905 | 86239 | 5000 | |
| Text | mount | 821 | 810 | 5000 | |
| TextField | mount | 1607 | 1544 | 5000 | |
| ThemeProvider | mount | 1473 | 1463 | 5000 | |
| ThemeProvider | virtual-rerender | 1141 | 1150 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2026 | 2039 | 5000 | |
| Toggle | mount | 1172 | 1144 | 5000 | |
| buttonNative | mount | 543 | 554 | 5000 |
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Oct 10, 2022
* master: (23 commits) Revert "chore: screener-run workflow should report to PR (microsoft#25144)" (microsoft#25145) chore: screener-run workflow should report to PR (microsoft#25144) applying package updates fix: The Tooltip should not hide if it gets keyboard focus (microsoft#25138) fix: Tooltip should not hide if an element inside it gets focused (microsoft#25140) Create react-migration-v8-v9 with shims and stories (microsoft#25121) fix: CheckboxField to set a generated ID on the input, to match the label's htmlFor (microsoft#25079) feat: Overflow menu should be registered in overflowManager (microsoft#25091) fix: version-bump generator removes beachball disallowedChangeType config (microsoft#25130) fix: new overflow items should only be enqueued while observing (microsoft#25122) fix(script): allow runPublished call from CLI (microsoft#25127) feat: add vertical variation for toolbar (microsoft#24940) ProgressField implementation and stories (microsoft#25103) fix: Dropdown icon layout with no placeholder/value (microsoft#25049) chore: add a bundle size fixture (Button, Provider & theme) (microsoft#25113) feat: Adding subtle transition between states on Button components (microsoft#25106) Revert "chore: screener-run workflow should report to PR (microsoft#25096)" (microsoft#25115) chore: screener-run workflow should report to PR (microsoft#25096) fix(react-dialog): aria-* properties should be reassignable (microsoft#25092) fix(scripts): don't run publish if web-components are affected (microsoft#25095) ...
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
…nfig (microsoft#25130) * fix: version-bump generator removes beachball disallowedChangeType config for nightly releases Fixes microsoft#25116 * update release pipeline to use lage * dependents shouldn't use carets for nightly * extract beachball config to separate types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25116