V9 Slider is missing cursor pointer #25184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report
Unchanged fixtures
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1272 | 1147 | 5000 | |
| Button | mount | 843 | 849 | 5000 | |
| FluentProvider | mount | 1496 | 1433 | 5000 | |
| FluentProviderWithTheme | mount | 615 | 633 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 591 | 594 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 539 | 568 | 10 | |
| MakeStyles | mount | 1696 | 1686 | 50000 | |
| SpinButton | mount | 2429 | 2303 | 5000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: c5377aa47efda4f692a5b61f5c85ea2fd0a590a4 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 754c462:
|
miroslavstastny
approved these changes
Oct 25, 2022
micahgodbolt
requested changes
Oct 25, 2022
|
Confirmed that this new behavior was actually in the spec, and we missed it on initial implementation. 🚢 it |
micahgodbolt
approved these changes
Oct 28, 2022
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
* cursor * change Co-authored-by: Petr Duda <[email protected]>
Hotell
pushed a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
* cursor * change Co-authored-by: Petr Duda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Slider V9 is missing cursor pointer when hovering or interacting with it.
New Behavior
This PR adds
cursor: pointerto the slider input and alsocursor: defaultfor input disabled state.Related Issue(s)
Fixes #