chore: fix syncpack glob pattern on apps folder #25465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1d0d72f:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: c619ba066f11a8654e95375314824ba6b81b003e (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1275 | 1286 | 5000 | |
| Button | mount | 912 | 921 | 5000 | |
| FluentProvider | mount | 1500 | 1506 | 5000 | |
| FluentProviderWithTheme | mount | 579 | 578 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 537 | 545 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 575 | 562 | 10 | |
| MakeStyles | mount | 1951 | 1952 | 50000 | |
| SpinButton | mount | 2341 | 2324 | 5000 |
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| SegmentMinimalPerf.default | 317 | 294 | 1.08:1 |
| AvatarMinimalPerf.default | 167 | 157 | 1.06:1 |
| RefMinimalPerf.default | 192 | 181 | 1.06:1 |
| ButtonMinimalPerf.default | 140 | 134 | 1.04:1 |
| CardMinimalPerf.default | 470 | 457 | 1.03:1 |
| DividerMinimalPerf.default | 318 | 310 | 1.03:1 |
| HeaderSlotsPerf.default | 694 | 671 | 1.03:1 |
| ListNestedPerf.default | 468 | 455 | 1.03:1 |
| ListWith60ListItems.default | 510 | 496 | 1.03:1 |
| PortalMinimalPerf.default | 140 | 136 | 1.03:1 |
| StatusMinimalPerf.default | 616 | 598 | 1.03:1 |
| TextMinimalPerf.default | 305 | 297 | 1.03:1 |
| TreeWith60ListItems.default | 136 | 132 | 1.03:1 |
| AttachmentMinimalPerf.default | 123 | 120 | 1.02:1 |
| BoxMinimalPerf.default | 302 | 297 | 1.02:1 |
| ChatDuplicateMessagesPerf.default | 212 | 208 | 1.02:1 |
| DropdownManyItemsPerf.default | 542 | 532 | 1.02:1 |
| FormMinimalPerf.default | 329 | 323 | 1.02:1 |
| GridMinimalPerf.default | 296 | 290 | 1.02:1 |
| HeaderMinimalPerf.default | 309 | 302 | 1.02:1 |
| ImageMinimalPerf.default | 340 | 334 | 1.02:1 |
| InputMinimalPerf.default | 863 | 846 | 1.02:1 |
| ListCommonPerf.default | 520 | 511 | 1.02:1 |
| CustomToolbarPrototype.default | 2172 | 2123 | 1.02:1 |
| ToolbarMinimalPerf.default | 798 | 784 | 1.02:1 |
| AlertMinimalPerf.default | 225 | 222 | 1.01:1 |
| AnimationMinimalPerf.default | 476 | 472 | 1.01:1 |
| ButtonSlotsPerf.default | 425 | 422 | 1.01:1 |
| CarouselMinimalPerf.default | 364 | 361 | 1.01:1 |
| DropdownMinimalPerf.default | 2174 | 2161 | 1.01:1 |
| EmbedMinimalPerf.default | 2654 | 2628 | 1.01:1 |
| ListMinimalPerf.default | 461 | 455 | 1.01:1 |
| LoaderMinimalPerf.default | 262 | 260 | 1.01:1 |
| MenuMinimalPerf.default | 739 | 732 | 1.01:1 |
| MenuButtonMinimalPerf.default | 1361 | 1347 | 1.01:1 |
| RosterPerf.default | 1723 | 1710 | 1.01:1 |
| ProviderMinimalPerf.default | 319 | 315 | 1.01:1 |
| SliderMinimalPerf.default | 1234 | 1227 | 1.01:1 |
| IconMinimalPerf.default | 566 | 562 | 1.01:1 |
| TableMinimalPerf.default | 353 | 351 | 1.01:1 |
| TextAreaMinimalPerf.default | 407 | 404 | 1.01:1 |
| TooltipMinimalPerf.default | 1892 | 1873 | 1.01:1 |
| TreeMinimalPerf.default | 698 | 689 | 1.01:1 |
| ButtonOverridesMissPerf.default | 1015 | 1013 | 1:1 |
| CheckboxMinimalPerf.default | 1535 | 1536 | 1:1 |
| DatepickerMinimalPerf.default | 4573 | 4588 | 1:1 |
| DialogMinimalPerf.default | 684 | 683 | 1:1 |
| FlexMinimalPerf.default | 253 | 253 | 1:1 |
| ItemLayoutMinimalPerf.default | 966 | 964 | 1:1 |
| LabelMinimalPerf.default | 340 | 339 | 1:1 |
| LayoutMinimalPerf.default | 315 | 314 | 1:1 |
| PopupMinimalPerf.default | 554 | 552 | 1:1 |
| RadioGroupMinimalPerf.default | 385 | 384 | 1:1 |
| SkeletonMinimalPerf.default | 298 | 298 | 1:1 |
| SplitButtonMinimalPerf.default | 3282 | 3267 | 1:1 |
| VideoMinimalPerf.default | 613 | 616 | 1:1 |
| AccordionMinimalPerf.default | 121 | 122 | 0.99:1 |
| ChatWithPopoverPerf.default | 290 | 294 | 0.99:1 |
| ReactionMinimalPerf.default | 330 | 332 | 0.99:1 |
| TableManyItemsPerf.default | 1544 | 1566 | 0.99:1 |
| AttachmentSlotsPerf.default | 879 | 895 | 0.98:1 |
| ChatMinimalPerf.default | 618 | 632 | 0.98:1 |
| ProviderMergeThemesPerf.default | 980 | 996 | 0.98:1 |
northstar is not using beachball thus fix-mismatch is used fluentui/scripts/fluentui-publish/index.ts Line 102 in 51eaa88 |
Hotell
approved these changes
Nov 1, 2022
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 1196 | 1211 | 5000 | |
| Breadcrumb | mount | 2946 | 2796 | 1000 | |
| Checkbox | mount | 2627 | 2647 | 5000 | |
| CheckboxBase | mount | 2372 | 2373 | 5000 | |
| ChoiceGroup | mount | 4286 | 4144 | 5000 | |
| ComboBox | mount | 1201 | 1169 | 1000 | |
| CommandBar | mount | 9212 | 9185 | 1000 | |
| ContextualMenu | mount | 10129 | 10069 | 1000 | |
| DefaultButton | mount | 1365 | 1363 | 5000 | |
| DetailsRow | mount | 3382 | 3329 | 5000 | |
| DetailsRowFast | mount | 3375 | 3342 | 5000 | |
| DetailsRowNoStyles | mount | 3272 | 3234 | 5000 | |
| Dialog | mount | 2952 | 2971 | 1000 | |
| DocumentCardTitle | mount | 578 | 588 | 1000 | |
| Dropdown | mount | 3127 | 3102 | 5000 | |
| FocusTrapZone | mount | 1952 | 1967 | 5000 | |
| FocusZone | mount | 1924 | 1885 | 5000 | |
| GroupedList | mount | 1803 | 2023 | 2 | |
| GroupedList | virtual-rerender | 1087 | 1101 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 1590 | 1597 | 2 | |
| GroupedListV2 | mount | 571 | 567 | 2 | |
| GroupedListV2 | virtual-rerender | 540 | 566 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 565 | 570 | 2 | |
| IconButton | mount | 1792 | 1796 | 5000 | |
| Label | mount | 748 | 747 | 5000 | |
| Layer | mount | 4120 | 4112 | 5000 | |
| Link | mount | 840 | 859 | 5000 | |
| MenuButton | mount | 1612 | 1613 | 5000 | |
| MessageBar | mount | 2381 | 2358 | 5000 | |
| Nav | mount | 3034 | 3055 | 1000 | |
| OverflowSet | mount | 1412 | 1417 | 5000 | |
| Panel | mount | 2465 | 2486 | 1000 | |
| Persona | mount | 1252 | 1264 | 1000 | |
| Pivot | mount | 1531 | 1536 | 1000 | |
| PrimaryButton | mount | 1486 | 1488 | 5000 | |
| Rating | mount | 6947 | 7029 | 5000 | |
| SearchBox | mount | 1494 | 1499 | 5000 | |
| Shimmer | mount | 2876 | 2907 | 5000 | |
| Slider | mount | 2110 | 2139 | 5000 | |
| SpinButton | mount | 4348 | 4276 | 5000 | |
| Spinner | mount | 841 | 835 | 5000 | |
| SplitButton | mount | 2862 | 2834 | 5000 | |
| Stack | mount | 859 | 864 | 5000 | |
| StackWithIntrinsicChildren | mount | 2315 | 2329 | 5000 | |
| StackWithTextChildren | mount | 5014 | 5019 | 5000 | |
| SwatchColorPicker | mount | 9506 | 9598 | 5000 | |
| TagPicker | mount | 2297 | 2383 | 5000 | |
| TeachingBubble | mount | 73471 | 74069 | 5000 | |
| Text | mount | 819 | 819 | 5000 | |
| TextField | mount | 1566 | 1565 | 5000 | |
| ThemeProvider | mount | 1448 | 1459 | 5000 | |
| ThemeProvider | virtual-rerender | 1137 | 1149 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1995 | 2006 | 5000 | |
| Toggle | mount | 1142 | 1137 | 5000 | |
| buttonNative | mount | 529 | 531 | 5000 |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Nov 2, 2022
* master: (23 commits) fix(docsite-v9): move theme picker under component title so it can be visible on embedded pages (microsoft#25385) applying package updates feat: Implement child render function for DataGrid rows (microsoft#25476) fix(useTable): sort should adapt to enhanced row types (microsoft#25487) applying package updates feat: positioning should happen out of React lifecycle (microsoft#25456) applying package updates chore(react-link): migrate to new package structure (microsoft#25471) chore(react-input): migrate to new package structure (microsoft#25469) fix glob pattern for syncpack (microsoft#25465) chore(react-label): migrate to new package structure (microsoft#25470) chore: bump Griffel to latest (microsoft#25412) chore: add few small toolbar improvements (microsoft#25468) docs: fix small typos (microsoft#25464) chore: fix dependencies in @fluentui/react-toolbar (microsoft#25466) feat: v0 menu style migration from v9 (microsoft#25012) applying package updates Update List to render children on first render() call (microsoft#25331) Scaffold react-skeleton package (microsoft#25435) fix(public-docsite): Changing crossplatform urls to use 'cross' instead of 'crossplatform' (microsoft#25437) ...
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
Hotell
pushed a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Glob we use before the change:
New glob work as expected:
This problem is discovered during fluentui upgrade. We upgraded fluentui to 0.65, apps/public-docsite-v9/package.json uses
"@fluentui/react-northstar": "^0.64.0", but syncpack didn't update it due to this issue