Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-components): stories for migrated v9 packages are included again #25540

Merged
merged 3 commits into from
Nov 4, 2022

Conversation

TristanWatanabe
Copy link
Member

Current Behavior

New Behavior

  • stories of migrated v9 packages are now included

Related Issue(s)

Part of #24129

@size-auditor
Copy link

size-auditor bot commented Nov 4, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 547d0184dbf41e4b42ffb13f6db2dac0fd85f70a (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 4, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
62.935 kB
17.686 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
189.901 kB
52.991 kB
react-components
react-components: FluentProvider & webLightTheme
33.446 kB
11.033 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
🤖 This report was generated against 547d0184dbf41e4b42ffb13f6db2dac0fd85f70a

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 4, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d70cc05:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 4, 2022

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1690 1835 5000
Button mount 1160 1149 5000
FluentProvider mount 1965 1951 5000
FluentProviderWithTheme mount 732 813 10
FluentProviderWithTheme virtual-rerender 686 698 10
FluentProviderWithTheme virtual-rerender-with-unmount 718 748 10
MakeStyles mount 2344 2329 50000
SpinButton mount 3377 3313 5000

@TristanWatanabe TristanWatanabe merged commit 13ef547 into microsoft:master Nov 4, 2022
@TristanWatanabe TristanWatanabe deleted the fix-v9-stories branch November 4, 2022 21:19
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants