feat(react-dialog): removes aria-haspopup
#25611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 518d14da9d2d826be43b6dc16ad9914ece82e07c (build) |
📊 Bundle size report
Unchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c2bdd6b:
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1594 | 1598 | 5000 | |
| Button | mount | 1121 | 1153 | 5000 | |
| FluentProvider | mount | 1938 | 1863 | 5000 | |
| FluentProviderWithTheme | mount | 749 | 745 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 706 | 692 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 754 | 752 | 10 | |
| MakeStyles | mount | 2276 | 2292 | 50000 | |
| SpinButton | mount | 2991 | 3049 | 5000 |
ling1726
reviewed
Nov 14, 2022
| @@ -82,7 +82,7 @@ describe('DialogTitle', () => { | |||
| mount( | |||
| <Dialog modalType="alert"> | |||
| <DialogTrigger disableButtonEnhancement> | |||
| <Button>Open dialog</Button> | |||
| <Button id={dialogTriggerOpenId}>Open dialog</Button> | |||
There was a problem hiding this comment.
why are all these ids necessary? I don't see them being used anywhere
There was a problem hiding this comment.
To make my life easier i just selected every single button at the same time and added them all these ids, probably they're not necessary on most places..... but it was so many tests that this was the quickest way 🙈
ling1726
approved these changes
Nov 14, 2022
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
* feat(react-dialog): removes aria-haspopup * chore: updates snapshot * chore: updates e2e trigger selectors
Hotell
pushed a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
* feat(react-dialog): removes aria-haspopup * chore: updates snapshot * chore: updates e2e trigger selectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Currently
DialogTriggerintroducesaria-haspopupto it's child to ensureaccessibility.New Behavior
As stated in #25151, we should be using
aria-expandedinstead ofaria-haspopuparia-haspopupforDialogTriggeraria-expandedforDialogTriggeraria-describedbyfromDialogSurfacearia-describedbyRelated Issue(s)
Fixes #25151