Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1JS VRT tooll add pipeline to generate V8 screenshots #25643
1JS VRT tooll add pipeline to generate V8 screenshots #25643
Changes from 103 commits
bbb79fa
f45d0c3
4928f2d
2c105b7
05869e7
54dd43e
4df01bc
f41bd23
811f617
0ce7f19
a610b33
4fd95a7
b50a509
d88034f
314dbd8
7ce33e7
a72b5b2
d14b3a8
f39bbf7
68d799b
7469281
740786d
b03d93d
dc5e39b
5063dfa
db1b63d
87a6f07
a601cae
3604361
97a7cc1
392a7ca
a6d649b
566f5ed
34f60d6
ebf5ca1
2ddad41
ba22f38
d345137
a27c089
c2ab7b1
ccfc0ad
80a9d6e
7e7b95b
f2729f0
553564c
dc3214f
6328e28
b8581fd
ab55b39
d9a6111
e938790
62d84e3
33247e5
001885b
218c55a
58df489
112acc3
d82c3ff
dc87c95
a356079
62fb2ac
c5ae72e
5407ff4
7eecb3b
87fd129
c90baf7
55900e4
20732df
2238679
525c2af
4d1d3c0
13c886b
eafc694
6d0710b
4446e90
eb46df0
2c2442b
a113259
4bb91ab
cac4860
16b044e
2eb737b
255c4ea
f88b530
232800d
f999d1c
42ded9e
4aa8ccc
ecb1c22
2d36782
1db4120
5e0639e
c997f32
6f46de0
b7c3f8f
d47412a
50edb97
aed0db1
99683c3
eb44f82
debc97e
639c7d8
6feff10
1db3cfb
f8a43c9
7af6ad0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for context, can you explain what this step is doing? And are all the secrets being referenced from the
fluent-vr-tool
Azure resource group?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step is responsible to
For baseline pipeline
For pr pipeline
Currently the secret are stored as secret variables in pipeline. The resource at the moment are pointing to our tests resurce group. As soon as piyush is back from sick leave we will point to resources in fluent-vr-tool resource group
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an arbitrary
pipelineId
or does it have some connection to an actual pipeline somewhere?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is arbitrary pipelineId. It's an id to identify particular job. Earlier since there was only job we just used the default pipelineid. But since now we have 2 jobs for V8,V9 in same pipeline we created two id's. As long as every job has unique id it should be fine