fix: Cell actions should have correct background when row focused within #25790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The table cell actions should appear when any focus is within the row and not just within the cell actions container. Also apply the hover background colour when the row has focus within. Now when the cell actions overlap the cell content, it will 'cover' the content just like in hover scenarios.
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: f7d7f82f6b3117ce163c6fee84b03c8774bed95f (build) |
📊 Bundle size report
Unchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f3ea809:
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1330 | 1311 | 5000 | |
| Button | mount | 941 | 949 | 5000 | |
| FluentProvider | mount | 1603 | 1594 | 5000 | |
| FluentProviderWithTheme | mount | 631 | 640 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 584 | 592 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 631 | 640 | 10 | |
| MakeStyles | mount | 1897 | 1913 | 50000 | |
| SpinButton | mount | 2571 | 2534 | 5000 |
🕵 fluentuiv9 Open the Visual Regressions report to inspect the 2 screenshots✅ There was 0 screenshots added, 0 screenshots removed, 1749 screenshots unchanged, 0 screenshots with different dimensions and 2 screenshots with visible difference. unknown 2 screenshots
|
layershifter
approved these changes
Nov 30, 2022
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Dec 1, 2022
* master: BREAKING: `useTable` renamed to `useTableFeatures` (microsoft#25797) chore: add retries for navigation in ssr-tests-v9 (microsoft#25844) fix: Cell actions should have correct background when row focused within (microsoft#25790) applying package updates Disable 3 Avatar Converged active stories (microsoft#25765) chore: introduce TS path aliases for improved DX in v8 (microsoft#25778) chore: prepare release react-northstar 0.65.0 (microsoft#25446) refactor(scripts): encapsulate v0 and v8 tooling within its domain boundaries (microsoft#25738) Support single point in area chart (microsoft#25842) chore: enable isolateModules in all v8 packages (microsoft#25774) chore: refactor styles for Button (microsoft#25216) feat: Improve docs for `DataGrid`, export as unstable (microsoft#25805) applying package updates fix: Allow data-selection-disabled to be respected by DetailsRow (microsoft#25836) docs(rfcs): Update recipes rfc with chosen option and add more details (microsoft#25823) chore(react-textarea): migrate to new package structure (microsoft#25820) chore(react-switch): migrate to new package structure (microsoft#25819) fix(react-avatar): AvatarGroup's pie layout places inline items correctly in rtl (microsoft#25822) chore: add few improvements to toolbar stories (microsoft#25635)
Hotell
pushed a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
…hin (microsoft#25790) * fix: Cell actions should have correct background when row focused within The table cell actions should appear when any focus is within the row and not just within the cell actions container. Also apply the hover background colour when the row has focus within. Now when the cell actions overlap the cell content, it will 'cover' the content just like in hover scenarios. * changefiles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The table cell actions should appear when any focus is within the row and not just within the cell actions container. Also apply the hover background colour when the row has focus within.
Now when the cell actions overlap the cell content, it will 'cover' the content just like in hover scenarios.
Also fixes
useFocusWithinso that the constant is no longer the same asuseFocusVisibleBefore
After
Fixes #25789