fix(TableHeaderCell): should render aria-sort="none" if not sorted
#25921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does not render `aria-sort` if not sorted renders `aria-sort="none"` if not sorted
layershifter
approved these changes
Dec 7, 2022
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 3b07bc7f5bbfbb21cba11676893867a78e440944 (build) |
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1311 | 1318 | 5000 | |
| Button | mount | 931 | 941 | 5000 | |
| FluentProvider | mount | 1587 | 1601 | 5000 | |
| FluentProviderWithTheme | mount | 632 | 630 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 597 | 591 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 615 | 622 | 10 | |
| MakeStyles | mount | 1914 | 1916 | 50000 | |
| Persona | mount | 3058 | 3005 | 5000 | |
| SpinButton | mount | 2542 | 2546 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit afa588f:
|
🕵 fluentuiv9 No visual regressions between this PR and main |
Hotell
pushed a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
…icrosoft#25921) * fix(TableHeaderCell): should render `aria-sort="none"` if not sorted Does not render `aria-sort` if not sorted renders `aria-sort="none"` if not sorted * changefile * only apply aria-sort if sortable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Does not render
aria-sortif not sortedNew Behavior
renders
aria-sort="none"if not sortedRelated Issue(s)