feat (CI): Enable 1JS VR tool to run on v7 #25946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 944b7e7:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: dc053c90ba404918eec40ccd61bfbae3db50ff9d (build) |
TristanWatanabe
commented
Dec 8, 2022
| @@ -2,7 +2,8 @@ | |||
| steps: | |||
| - task: NodeTool@0 | |||
| inputs: | |||
| versionSpec: '12.x' | |||
| versionSpec: '14.18.1' | |||
There was a problem hiding this comment.
bumps agent host machine node version to 14.18.1 to align with master and to make it compatible with the storywright tool.
🕵 FluentUI-v7 Open the Visual Regressions report to inspect the 1271 screenshots✅ There was 1271 screenshots added, 0 screenshots removed, 102 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference. OverflowSet.Root - RTL.default.chromium 1 screenshots
OverflowSet.Root.default.chromium 1 screenshots
SearchBox.Full - RTL.default.chromium 1 screenshots
SearchBox.Full.default.chromium 1 screenshots
SearchBox.Root - RTL.default.chromium 1 screenshots
SearchBox.Root.default.chromium 1 screenshots
unknown 1265 screenshots
|
Perf AnalysisNo significant results to display. All results
|
TristanWatanabe
changed the title
TristanWatanabe
changed the title
micahgodbolt
approved these changes
Dec 9, 2022
GeoffCoxMSFT
reviewed
Dec 9, 2022
| #!/usr/bin/env bash | ||
|
|
||
| find ./src -type f |while read fname; do | ||
| impor="" |
There was a problem hiding this comment.
Will address in follow-up PRs with cleanups!
GeoffCoxMSFT
approved these changes
Dec 9, 2022
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
nodeversion to version14.18.1to align with master and since it's incompatible with thestorywrighttool.convert,build-storybook,vrt:buildscripts needed to run vr tests in pipeline.storywrightandvrscreenshotdiffNote: The v7 branch will share the
VR Tool Pipeline - PRpipeline with the master branch but will have its own separateVR Tool - Baseline (v7)pipeline.Related Issue(s)