Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore (v7 vr-tests): Completely remove usage of Screener #26049

Merged

Conversation

TristanWatanabe
Copy link
Member

@TristanWatanabe TristanWatanabe commented Dec 20, 2022

Changes:

  • removes Screener specific configs and scripts from vr-tests package and repo (lage, root package.json).
  • removes Screener related dependencies from package.json.
    • updates yarn.lock file to remove Screener dependencies
  • Replaces Screener tags with StoryWright tags,
  • Replaces screener related imports with storywright.
  • Removes convert script from vr-tests package and invocation of it by the runpublishscreenshot template since they are no longer necessary.

Related Issue(s)

@TristanWatanabe TristanWatanabe requested a review from a team as a code owner December 20, 2022 19:48
@TristanWatanabe TristanWatanabe self-assigned this Dec 20, 2022
@msft-fluent-ui-bot msft-fluent-ui-bot added Fabric 7 needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master labels Dec 20, 2022
Copy link
Collaborator

@msft-fluent-ui-bot msft-fluent-ui-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this change to the 7.0 branch may not have been submitted to master yet. Now that version 8 has released, all changes must be submitted to the master branch first (except in emergencies or if the change is irrelevant to version 8).

Please do one of the following:

  • If you've already created a PR to master, add a link to it
  • If the change is irrelevant to version 8, add a comment explaining why
  • Otherwise, create a PR to master with this same change, and add a link to it

After that, you can dismiss this review and remove the "needs cherry-pick" label (or ask a team member to help do so).

Want to avoid this in the future? Include text like "Cherry-pick of ####" in the PR description (where #### is the real master PR number).

@TristanWatanabe TristanWatanabe removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Dec 20, 2022
@TristanWatanabe TristanWatanabe removed the request for review from msft-fluent-ui-bot December 20, 2022 19:50
@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 20, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 35a4339:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@size-auditor
Copy link

size-auditor bot commented Dec 20, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: f5a186ae8f17bc97aae19de9403ca15350bc1cab (build)

@fabricteam
Copy link
Collaborator

🕵 FluentUI-v7 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 1147 1136 5000
Breadcrumb mount 35720 35490 5000
Checkbox mount 1645 1666 5000
CheckboxBase mount 1435 1418 5000
ChoiceGroup mount 4420 4427 5000
ComboBox mount 1055 1078 1000
CommandBar mount 6835 6873 1000
ContextualMenu mount 11703 10637 1000
DefaultButton mount 1311 1306 5000
DetailsRow mount 3383 3386 5000
DetailsRowFast mount 3406 3417 5000
DetailsRowNoStyles mount 3240 3253 5000
Dialog mount 2117 2139 1000
DocumentCardTitle mount 1848 1883 1000
Dropdown mount 2376 2374 5000
FocusTrapZone mount 1796 1767 5000
FocusZone mount 1907 1881 5000
GroupedList mount 801 873 2
GroupedListV2 mount 494 499 2
IconButton mount 1735 1738 5000
Label mount 679 673 5000
Layer mount 2011 1993 5000
Link mount 784 780 5000
MenuButton mount 1551 1552 5000
MessageBar mount 2119 2145 5000
Nav mount 2964 2967 1000
OverflowSet mount 1540 1554 5000
Panel mount 1536 1562 1000
Persona mount 1156 1182 1000
Pivot mount 1454 1478 1000
PrimaryButton mount 1401 1430 5000
Rating mount 6996 7019 5000
SearchBox mount 1459 1435 5000
Shimmer mount 2657 2644 5000
Slider mount 1644 1641 5000
SpinButton mount 4234 4321 5000
Spinner mount 758 765 5000
SplitButton mount 2806 2852 5000
Stack mount 837 828 5000
StackWithIntrinsicChildren mount 1709 1719 5000
StackWithTextChildren mount 4593 4599 5000
SwatchColorPicker mount 8437 8330 5000
TagPicker mount 2517 2469 5000
TeachingBubble mount 41624 41674 5000
Text mount 779 768 5000
TextField mount 1498 1518 5000
Toggle mount 1107 1117 5000
button mount 466 459 5000

@TristanWatanabe TristanWatanabe merged commit 64f0a87 into microsoft:7.0 Dec 21, 2022
@TristanWatanabe TristanWatanabe deleted the 7.0-remove-screener-things branch December 21, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants