Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-tags-preview): properly type ref in state hook #29316

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

YuanboXue-Amber
Copy link
Contributor

Update ref typing in state hook from the default React.Ref<HTMLElement> from template, to proper type

@YuanboXue-Amber YuanboXue-Amber requested review from a team as code owners September 27, 2023 13:33
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 378df4f:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 27, 2023

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-tags-preview
InteractionTag
14.275 kB
5.717 kB
react-tags-preview
Tag
28.998 kB
9.061 kB
react-tags-preview
TagGroup
72.507 kB
21.605 kB
🤖 This report was generated against bb6155adb0828619519ec1a871d9628acf3b9a38

@YuanboXue-Amber
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@size-auditor
Copy link

size-auditor bot commented Sep 27, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: bb6155adb0828619519ec1a871d9628acf3b9a38 (build)

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@YuanboXue-Amber YuanboXue-Amber merged commit 6e692ab into microsoft:master Sep 27, 2023
@YuanboXue-Amber YuanboXue-Amber deleted the tag-ref branch September 27, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants