fix(web-components): update switch to use margin for checked state to support RTL #29505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report🤖 This report was generated against 66952983572126c1c609a00511c5a89cadc91f28 |
fabricteam
reviewed
Oct 11, 2023
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵 fluentui-web-components-v3 Open the Visual Regressions report to inspect the affected screenshots
Switch 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Switch.Checked - RTL.hover.chromium.png | 104 | Changed |
| Switch.Checked - RTL.normal.chromium.png | 97 | Changed |
There was a problem hiding this comment.
Switch.Checked - RTL.normal.chromium.png
Switch.Checked - RTL.hover.chromium.png
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 66952983572126c1c609a00511c5a89cadc91f28 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e39e186:
|
|
Lgtm |
atulkatti
approved these changes
Oct 12, 2023
eljefe223
approved these changes
Oct 12, 2023
miroslavstastny
approved these changes
Oct 12, 2023
chrisdholt
added a commit
that referenced
this pull request
Apr 29, 2024
… support RTL (#29505) * use margin for switch checked transition to support RTL * change files
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
… support RTL (microsoft#29505) * use margin for switch checked transition to support RTL * change files
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
… support RTL (microsoft#29505) * use margin for switch checked transition to support RTL * change files
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 30, 2024
… support RTL (microsoft#29505) * use margin for switch checked transition to support RTL * change files
radium-v
pushed a commit
that referenced
this pull request
Apr 30, 2024
… support RTL (#29505) * use margin for switch checked transition to support RTL * change files
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
… support RTL (#29505) * use margin for switch checked transition to support RTL * change files
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
… support RTL (#29505) * use margin for switch checked transition to support RTL * change files
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
… support RTL (#29505) * use margin for switch checked transition to support RTL * change files
radium-v
pushed a commit
that referenced
this pull request
May 3, 2024
… support RTL (#29505) * use margin for switch checked transition to support RTL * change files
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
… support RTL (#29505) * use margin for switch checked transition to support RTL * change files
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
… support RTL (#29505) * use margin for switch checked transition to support RTL * change files
radium-v
pushed a commit
that referenced
this pull request
May 8, 2024
… support RTL (#29505) * use margin for switch checked transition to support RTL * change files
radium-v
pushed a commit
that referenced
this pull request
May 10, 2024
… support RTL (#29505) * use margin for switch checked transition to support RTL * change files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Switch used a transform to move the indicator to the checked state which led to an issue where there wasn't immediate support for RTL.
New Behavior
This PR updates the code to leverage margin-inline-start instead which allows for this to be automatically accommodated in RTL scenarios.
Related Issue(s)