-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Rating to stable #30740
Merged
tomi-msft
merged 11 commits into
microsoft:master
from
tomi-msft:react-rating-stable-release
Mar 15, 2024
Merged
Release Rating to stable #30740
tomi-msft
merged 11 commits into
microsoft:master
from
tomi-msft:react-rating-stable-release
Mar 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eact-rating-stable-release
khmakoto
reviewed
Mar 7, 2024
change/@fluentui-react-components-087b13a4-0891-45b2-9166-3f35a1d04ff8.json
Outdated
Show resolved
Hide resolved
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 628 | 671 | 5000 | |
Button | mount | 311 | 298 | 5000 | |
Field | mount | 1107 | 1124 | 5000 | |
FluentProvider | mount | 736 | 742 | 5000 | |
FluentProviderWithTheme | mount | 96 | 120 | 10 | |
FluentProviderWithTheme | virtual-rerender | 63 | 71 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 136 | 120 | 10 | |
MakeStyles | mount | 900 | 925 | 50000 | |
Persona | mount | 1779 | 1739 | 5000 | |
SpinButton | mount | 1494 | 1371 | 5000 |
Perf Analysis (
|
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
DividerMinimalPerf.default | 218 | 195 | 1.12:1 |
AttachmentMinimalPerf.default | 83 | 77 | 1.08:1 |
TableMinimalPerf.default | 244 | 225 | 1.08:1 |
AvatarMinimalPerf.default | 112 | 105 | 1.07:1 |
HeaderMinimalPerf.default | 220 | 206 | 1.07:1 |
LayoutMinimalPerf.default | 213 | 199 | 1.07:1 |
ListMinimalPerf.default | 327 | 307 | 1.07:1 |
LoaderMinimalPerf.default | 199 | 186 | 1.07:1 |
AttachmentSlotsPerf.default | 625 | 592 | 1.06:1 |
CarouselMinimalPerf.default | 267 | 253 | 1.06:1 |
ChatDuplicateMessagesPerf.default | 152 | 144 | 1.06:1 |
BoxMinimalPerf.default | 201 | 191 | 1.05:1 |
ButtonMinimalPerf.default | 91 | 87 | 1.05:1 |
ProviderMinimalPerf.default | 210 | 200 | 1.05:1 |
ReactionMinimalPerf.default | 212 | 201 | 1.05:1 |
TextAreaMinimalPerf.default | 292 | 279 | 1.05:1 |
ButtonSlotsPerf.default | 329 | 317 | 1.04:1 |
EmbedMinimalPerf.default | 1883 | 1817 | 1.04:1 |
GridMinimalPerf.default | 201 | 194 | 1.04:1 |
LabelMinimalPerf.default | 226 | 217 | 1.04:1 |
ListWith60ListItems.default | 373 | 359 | 1.04:1 |
SkeletonMinimalPerf.default | 204 | 197 | 1.04:1 |
TextMinimalPerf.default | 201 | 193 | 1.04:1 |
DropdownMinimalPerf.default | 1439 | 1401 | 1.03:1 |
FormMinimalPerf.default | 223 | 217 | 1.03:1 |
ImageMinimalPerf.default | 226 | 219 | 1.03:1 |
RefMinimalPerf.default | 110 | 107 | 1.03:1 |
SliderMinimalPerf.default | 759 | 740 | 1.03:1 |
TreeMinimalPerf.default | 496 | 483 | 1.03:1 |
ChatMinimalPerf.default | 439 | 431 | 1.02:1 |
FlexMinimalPerf.default | 158 | 155 | 1.02:1 |
MenuButtonMinimalPerf.default | 978 | 956 | 1.02:1 |
PortalMinimalPerf.default | 85 | 83 | 1.02:1 |
RadioGroupMinimalPerf.default | 261 | 255 | 1.02:1 |
TableManyItemsPerf.default | 1119 | 1096 | 1.02:1 |
AlertMinimalPerf.default | 153 | 152 | 1.01:1 |
InputMinimalPerf.default | 535 | 528 | 1.01:1 |
ItemLayoutMinimalPerf.default | 694 | 686 | 1.01:1 |
ListCommonPerf.default | 398 | 396 | 1.01:1 |
MenuMinimalPerf.default | 511 | 507 | 1.01:1 |
CustomToolbarPrototype.default | 1498 | 1487 | 1.01:1 |
CardMinimalPerf.default | 311 | 311 | 1:1 |
DialogMinimalPerf.default | 447 | 446 | 1:1 |
DropdownManyItemsPerf.default | 382 | 383 | 1:1 |
HeaderSlotsPerf.default | 463 | 463 | 1:1 |
PopupMinimalPerf.default | 352 | 352 | 1:1 |
SegmentMinimalPerf.default | 192 | 192 | 1:1 |
StatusMinimalPerf.default | 385 | 386 | 1:1 |
AccordionMinimalPerf.default | 83 | 84 | 0.99:1 |
ButtonOverridesMissPerf.default | 644 | 649 | 0.99:1 |
CheckboxMinimalPerf.default | 1134 | 1145 | 0.99:1 |
ProviderMergeThemesPerf.default | 646 | 652 | 0.99:1 |
SplitButtonMinimalPerf.default | 2238 | 2252 | 0.99:1 |
AnimationMinimalPerf.default | 299 | 304 | 0.98:1 |
DatepickerMinimalPerf.default | 3774 | 3839 | 0.98:1 |
RosterPerf.default | 1543 | 1575 | 0.98:1 |
TooltipMinimalPerf.default | 1254 | 1280 | 0.98:1 |
ChatWithPopoverPerf.default | 183 | 188 | 0.97:1 |
ListNestedPerf.default | 315 | 324 | 0.97:1 |
ToolbarMinimalPerf.default | 538 | 552 | 0.97:1 |
IconMinimalPerf.default | 398 | 415 | 0.96:1 |
VideoMinimalPerf.default | 422 | 440 | 0.96:1 |
TreeWith60ListItems.default | 85 | 90 | 0.94:1 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
🕵 fluentuiv8 No visual regressions between this PR and main |
🕵 FluentUIV0 No visual regressions between this PR and main |
📊 Bundle size reportUnchanged fixtures
|
🕵 fluentuiv9 No visual regressions between this PR and main |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
BaseButton | mount | 610 | 617 | 5000 | |
Breadcrumb | mount | 1641 | 1674 | 1000 | |
Checkbox | mount | 1722 | 1678 | 5000 | |
CheckboxBase | mount | 1483 | 1522 | 5000 | |
ChoiceGroup | mount | 2975 | 2926 | 5000 | |
ComboBox | mount | 635 | 668 | 1000 | |
CommandBar | mount | 6124 | 6296 | 1000 | |
ContextualMenu | mount | 12789 | 12369 | 1000 | |
DefaultButton | mount | 766 | 754 | 5000 | |
DetailsRow | mount | 2171 | 2172 | 5000 | |
DetailsRowFast | mount | 2256 | 2253 | 5000 | |
DetailsRowNoStyles | mount | 2014 | 2046 | 5000 | |
Dialog | mount | 2647 | 2806 | 1000 | |
DocumentCardTitle | mount | 227 | 231 | 1000 | |
Dropdown | mount | 1979 | 1973 | 5000 | |
FocusTrapZone | mount | 1135 | 1141 | 5000 | |
FocusZone | mount | 1064 | 1075 | 5000 | |
GroupedList | mount | 41570 | 41752 | 2 | |
GroupedList | virtual-rerender | 20092 | 20044 | 2 | |
GroupedList | virtual-rerender-with-unmount | 50507 | 50798 | 2 | |
GroupedListV2 | mount | 227 | 223 | 2 | |
GroupedListV2 | virtual-rerender | 207 | 209 | 2 | |
GroupedListV2 | virtual-rerender-with-unmount | 224 | 224 | 2 | |
IconButton | mount | 1084 | 1087 | 5000 | |
Label | mount | 328 | 335 | 5000 | |
Layer | mount | 2694 | 2677 | 5000 | |
Link | mount | 399 | 393 | 5000 | |
MenuButton | mount | 930 | 944 | 5000 | |
MessageBar | mount | 21441 | 21674 | 5000 | |
Nav | mount | 1947 | 1975 | 1000 | |
OverflowSet | mount | 798 | 787 | 5000 | |
Panel | mount | 1794 | 1812 | 1000 | |
Persona | mount | 750 | 745 | 1000 | |
Pivot | mount | 867 | 876 | 1000 | |
PrimaryButton | mount | 845 | 829 | 5000 | |
Rating | mount | 4631 | 4601 | 5000 | |
SearchBox | mount | 930 | 917 | 5000 | |
Shimmer | mount | 1866 | 1837 | 5000 | |
Slider | mount | 1351 | 1339 | 5000 | |
SpinButton | mount | 2896 | 2818 | 5000 | |
Spinner | mount | 381 | 389 | 5000 | |
SplitButton | mount | 1805 | 1842 | 5000 | |
Stack | mount | 419 | 394 | 5000 | |
StackWithIntrinsicChildren | mount | 848 | 845 | 5000 | |
StackWithTextChildren | mount | 2568 | 2581 | 5000 | |
SwatchColorPicker | mount | 6214 | 6055 | 5000 | |
TagPicker | mount | 1469 | 1440 | 5000 | |
Text | mount | 359 | 369 | 5000 | |
TextField | mount | 944 | 934 | 5000 | |
ThemeProvider | mount | 825 | 841 | 5000 | |
ThemeProvider | virtual-rerender | 586 | 586 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1292 | 1311 | 5000 | |
Toggle | mount | 616 | 614 | 5000 | |
buttonNative | mount | 184 | 198 | 5000 |
Hotell
reviewed
Mar 8, 2024
…eact-rating-stable-release
…-msft/fluentui into react-rating-stable-release
JustSlone
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signing off on CODEOWNERS change
khmakoto
approved these changes
Mar 12, 2024
TristanWatanabe
approved these changes
Mar 15, 2024
change/@fluentui-react-components-087b13a4-0891-45b2-9166-3f35a1d04ff8.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Tristan Watanabe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to release
Rating
to stable.