fix(web-components): ensure buttons with long text maintain center alignment #31179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdholt
force-pushed
the
users/chhol/fix-button-vr-tests
branch
from
b500d93 to
6f97f26
Compare
chrisdholt
changed the title
📊 Bundle size report🤖 This report was generated against b8e0cea8051975886a2d8553bf2771d85a5dd283 |
fabricteam
reviewed
Apr 24, 2024
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵 fluentui-web-components-v3 Open the Visual Regressions report to inspect the affected screenshots
Text 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Text.Block.normal.chromium.png | 995 | Changed |
chrisdholt
merged commit ee42c7c
into
microsoft:web-components-v3
16 of 17 checks passed
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
chrisdholt
added a commit
that referenced
this pull request
Apr 29, 2024
…ignment (#31179) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
…ignment (microsoft#31179) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
…ignment (microsoft#31179) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 30, 2024
…ignment (microsoft#31179) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
that referenced
this pull request
Apr 30, 2024
…ignment (#31179) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
…ignment (#31179) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
…ignment (#31179) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
…ignment (#31179) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
that referenced
this pull request
May 3, 2024
…ignment (#31179) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
…ignment (#31179) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
…ignment (#31179) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
that referenced
this pull request
May 8, 2024
…ignment (#31179) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
that referenced
this pull request
May 10, 2024
…ignment (#31179) Co-authored-by: Christopher Holt <=>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Behavior regressed for buttons with long text.
New Behavior
This PR ensures that buttons with long text have the text center aligned when wrapping.
Related Issue(s)