Update Accordion Size story to allow collapsing #31624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender-with-unmount | 81 | 81 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 627 | 662 | 5000 | |
| Button | mount | 305 | 310 | 5000 | |
| Field | mount | 1120 | 1130 | 5000 | |
| FluentProvider | mount | 712 | 734 | 5000 | |
| FluentProviderWithTheme | mount | 77 | 87 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 38 | 35 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 81 | 81 | 10 | Possible regression |
| MakeStyles | mount | 856 | 863 | 50000 | |
| Persona | mount | 1799 | 1716 | 5000 | |
| SpinButton | mount | 1403 | 1402 | 5000 | |
| SwatchPicker | mount | 1522 | 1543 | 5000 |
📊 Bundle size report✅ No changes found |
fabricteam
reviewed
Jun 7, 2024
packages/react-components/react-accordion/stories/Accordion/AccordionSizes.stories.tsx
Show resolved
Hide resolved
spmonahan
approved these changes
Jun 7, 2024
packages/react-components/react-accordion/stories/Accordion/AccordionSizes.stories.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-accordion/stories/Accordion/AccordionSizes.stories.tsx
Outdated
Show resolved
Hide resolved
mainframev
pushed a commit
to mainframev/fluentui
that referenced
this pull request
Jun 11, 2024
Add collapsible to the accordions in this story, and update the header text to be more descriptive. Note: an alternative would be to combine the sizes into a single accordion panel, but mixing sizes in a single accordion isn't recommended, and we prefer to avoid non-recommended usages in story examples.
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 11, 2024
…-and-drawer-compat * master: (43 commits) chore: remove react-alert from monorepo (microsoft#31642) docs(react-skeleton): extend Skeleton story with SkeletonItem examples (microsoft#31608) feat(react-motion): add support for params (microsoft#31566) applying package updates fix: show default title action in dialog body for modal dialogs (microsoft#31648) chore:(react-nav-preview)Remove redundant NavDrawerHeaderNav component. (microsoft#31646) Update Accordion Size story to allow collapsing (microsoft#31624) fix(react-accordion): deprecate navigation prop (microsoft#31587) fix: Drawer story accessibility fixes and docs update (microsoft#31570) feat:(react-nav-preview) Adds small size variant (microsoft#31589) feat: update divider to use element internals (microsoft#31627) chore(react-components): split react libraries in two (/library and /stories) - teams-prg /3rd batch (microsoft#31601) chore:(docs) Adding Jest testing document (microsoft#31554) chore(react-components): split react libraries in two (/library and /stories) - teams-prg /2nd batch (microsoft#31600) build(deps): bump tar from 6.1.11 to 6.2.1 (microsoft#31633) applying package updates fix: allow updating of CSS properties when they are already defined (microsoft#31629) fix: corrects the border-color for switch when in the checked state on rest (microsoft#31628) chore: update Switch to leverage ElementInternals via Checkbox (microsoft#31613) chore: update temporarily codeowners for split-in-two migrated packages to maintain proper PR review assignemnt for outdated branches (microsoft#31616) ...
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 11, 2024
* master: (43 commits) chore: remove react-alert from monorepo (microsoft#31642) docs(react-skeleton): extend Skeleton story with SkeletonItem examples (microsoft#31608) feat(react-motion): add support for params (microsoft#31566) applying package updates fix: show default title action in dialog body for modal dialogs (microsoft#31648) chore:(react-nav-preview)Remove redundant NavDrawerHeaderNav component. (microsoft#31646) Update Accordion Size story to allow collapsing (microsoft#31624) fix(react-accordion): deprecate navigation prop (microsoft#31587) fix: Drawer story accessibility fixes and docs update (microsoft#31570) feat:(react-nav-preview) Adds small size variant (microsoft#31589) feat: update divider to use element internals (microsoft#31627) chore(react-components): split react libraries in two (/library and /stories) - teams-prg /3rd batch (microsoft#31601) chore:(docs) Adding Jest testing document (microsoft#31554) chore(react-components): split react libraries in two (/library and /stories) - teams-prg /2nd batch (microsoft#31600) build(deps): bump tar from 6.1.11 to 6.2.1 (microsoft#31633) applying package updates fix: allow updating of CSS properties when they are already defined (microsoft#31629) fix: corrects the border-color for switch when in the checked state on rest (microsoft#31628) chore: update Switch to leverage ElementInternals via Checkbox (microsoft#31613) chore: update temporarily codeowners for split-in-two migrated packages to maintain proper PR review assignemnt for outdated branches (microsoft#31616) ...
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
Add collapsible to the accordions in this story, and update the header text to be more descriptive. Note: an alternative would be to combine the sizes into a single accordion panel, but mixing sizes in a single accordion isn't recommended, and we prefer to avoid non-recommended usages in story examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The Accordion Size story has multiple different accordions to show the different sizes, but appears broken because they can't be collapsed when another is opened.
New Behavior
Add
collapsibleto the accordions in this story, and update the header text to be more descriptive.Note: an alternative would be to combine the sizes into a single accordion panel, but mixing sizes in a single accordion isn't recommended, and we prefer to avoid non-recommended usages in story examples.
Related Issue(s)