(web-components): Create rating-display component #31625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igh contrast colors.
…igh contrast colors.
…into rating-display
There was a problem hiding this comment.
Great work @mlijanto! This all looks pretty good to me. Just a couple questions.
packages/web-components/src/rating-display/rating-display.template.ts
Outdated
Show resolved
Hide resolved
chrisdholt
reviewed
Jun 11, 2024
packages/web-components/src/rating-display/rating-display.template.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/rating-display/rating-display.template.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/rating-display/rating-display.template.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/rating-display/rating-display.styles.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/rating-display/rating-display.template.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/rating-display/rating-display.template.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/rating-display/rating-display.styles.ts
Outdated
Show resolved
Hide resolved
chrisdholt
reviewed
Jun 19, 2024
chrisdholt
reviewed
Jun 19, 2024
chrisdholt
reviewed
Jun 19, 2024
chrisdholt
reviewed
Jun 19, 2024
chrisdholt
reviewed
Jun 19, 2024
chrisdholt
reviewed
Jun 19, 2024
chrisdholt
reviewed
Jun 19, 2024
packages/web-components/src/rating-display/rating-display.styles.ts
Outdated
Show resolved
Hide resolved
chrisdholt
reviewed
Jun 19, 2024
packages/web-components/src/rating-display/rating-display.styles.ts
Outdated
Show resolved
Hide resolved
chrisdholt
reviewed
Jun 19, 2024
marchbox
reviewed
Jun 19, 2024
eljefe223
reviewed
Jun 24, 2024
packages/web-components/src/rating-display/rating-display.template.ts
Outdated
Show resolved
Hide resolved
eljefe223
reviewed
Jun 24, 2024
chrisdholt
reviewed
Jun 26, 2024
chrisdholt
approved these changes
Jun 26, 2024
eljefe223
approved these changes
Jun 26, 2024
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
📊 Bundle size report✅ No changes found |
fabricteam
reviewed
Jun 26, 2024
change/@fluentui-web-components-57457815-4425-499a-af44-9122e4acae14.json
Show resolved
Hide resolved
davatron5000
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Before this PR, the web-components package did not include a rating-display component.
New Behavior
This PR adds a new rating-display component, designed to show a rating value. Because the component is non-interactive, from an accessibility perspective, it is considered a single image and labeled by the value label.
Available attributes: