feat: add link as new web component #31676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdholt
force-pushed
the
users/chhol/add-link-as-new-web-component
branch
from
565ec1e to
60ef43c
Compare
📊 Bundle size report✅ No changes found |
fabricteam
reviewed
Jun 12, 2024
chrisdholt
force-pushed
the
users/chhol/add-link-as-new-web-component
branch
3 times, most recently
from
e02cb23 to
527dfc4
Compare
chrisdholt
force-pushed
the
users/chhol/add-link-as-new-web-component
branch
from
527dfc4 to
aad75f4
Compare
davatron5000
approved these changes
Jun 12, 2024
mlijanto
reviewed
Jun 12, 2024
| } as const; | ||
|
|
||
| /** | ||
| * An Link can be secondary, primary, outline, subtle, transparent |
There was a problem hiding this comment.
Is this comment accurate? Looks like LinkAppearance above only has subtle as an option.
mlijanto
reviewed
Jun 12, 2024
| import type { Link } from './link.js'; | ||
|
|
||
| /** | ||
| * The template for the Button component. |
There was a problem hiding this comment.
Should this say "Link" instead of "Button?" Same question for another comment below.
There was a problem hiding this comment.
Yes - I'll push a PR 🗡️
mlijanto
reviewed
Jun 12, 2024
| * HTML Attribute: `inline` | ||
| */ | ||
| @attr({ mode: 'boolean' }) | ||
| public inline?: boolean = false; |
There was a problem hiding this comment.
Nit: if this property has a default value then it doesn't need to be marked as optional.
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
N/A
New Behavior
This PR adds link as a new web component.
Related Issue(s)