fix: ensure menu keydown logic allows shift+tab to navigate as expected #31849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlijanto
approved these changes
Jun 27, 2024
marchbox
approved these changes
Jun 27, 2024
📊 Bundle size report✅ No changes found |
fabricteam
reviewed
Jun 27, 2024
change/@fluentui-web-components-d7ebd73e-6662-488f-a6c8-3715eea02229.json
Show resolved
Hide resolved
chrisdholt
force-pushed
the
users/chhol/fix-shift-tab-focus-on-menu
branch
from
aeffd87 to
53d82bb
Compare
davatron5000
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Shift+Tab was being suppressed due to the logic of menu not accounting for the trigger being focused already when the menu was closed
New Behavior
Shift+Tab when the menu is closed works as expected
Related Issue(s)