-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web-components): change slider to use Element Internals #31933
feat(web-components): change slider to use Element Internals #31933
Conversation
@chrisdholt Oh never mind, mis read your message. Yeah I'll add that in Field's story. |
I saw there is an example under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @marchbox! I only left a few small comments. Thanks!
…chbox/fluentui into users/machi/slider-element-internals
Previous Behavior
<input type=range>
New Behavior
Built based on @chrisdholt’s original changes.
willValidate
,reportValidity()
, etc.<fieldset>
element will also update the component’s disabled state, if not explicitly set yetvalueTextFormatter
will updateariaValueText
now.min
,max
andstep
are now always string type (but can accept non-string values when setting)readonly
support to align with<input type=range>
(authors can still addaria-readonly
to the component)Related Issue(s)