Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web-components): complete detach design tokens from existing themes #32130

Merged
merged 18 commits into from
Aug 3, 2024
Merged

fix(web-components): complete detach design tokens from existing themes #32130

merged 18 commits into from
Aug 3, 2024

Conversation

marchbox
Copy link
Contributor

@marchbox marchbox commented Jul 27, 2024 •
edited
Loading

Previous Behavior

Only existing defined tokens can be set as part of the theme, custom tokens are ignored.

New Behavior

  • Completed detach the theme object used in setTheme() from existing tokens. This allows arbitrary tokens to be set as CSS Custom Properties.
  • If a theme object contains entries which values are not either strings or numbers, the function will throw
  • Improved the story for setTheme() in Storybook

Related Issue(s)

  • Fixes #

@marchbox marchbox self-assigned this Jul 27, 2024
@marchbox marchbox requested a review from a team as a code owner July 27, 2024 00:22
@fabricteam
Copy link
Collaborator

fabricteam commented Jul 27, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 27, 2024 •
edited
Loading

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

davatron5000
davatron5000 approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@davatron5000 davatron5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The improvements look good to me. Appreciate the additional documentation.

@marchbox marchbox merged commit 89959ae into microsoft:master Aug 3, 2024
18 checks passed
@marchbox marchbox deleted the users/machi/settheme-custom branch August 3, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radium-v radium-v radium-v left review comments

@davatron5000 davatron5000 davatron5000 approved these changes

Assignees

@marchbox marchbox

Labels
web-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marchbox @fabricteam @davatron5000 @radium-v