[chore]: [rating-display] move size, color and compact. #32239
Merged
+131
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
mlijanto
reviewed
Aug 6, 2024
mlijanto
reviewed
Aug 6, 2024
mlijanto
reviewed
Aug 6, 2024
eljefe223
force-pushed
the
users/jes/rating-base-class
branch
from
cac4784 to
21aa7a9
Compare
mlijanto
reviewed
Aug 7, 2024
mlijanto
approved these changes
Aug 7, 2024
eljefe223
force-pushed
the
users/jes/rating-base-class
branch
from
21aa7a9 to
49bd6e1
Compare
bsunderhus
pushed a commit
to bsunderhus/fluentui
that referenced
this pull request
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
compact,sizeandcolorare style and layout specific to fluent.generateIconsneeds to exist in both the base class and extended class to keep base class functional.New Behavior
moves
compact,sizeandcolor.Related Issue(s)