Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web-components): tooltip positioning style for 'below-end' option #33494

Merged
merged 4 commits into from
Dec 20, 2024
Merged

fix(web-components): tooltip positioning style for 'below-end' option #33494

merged 4 commits into from
Dec 20, 2024

Conversation

radium-v
Copy link
Contributor

Previous Behavior

  • The below-end style for the Tooltip component was set to below.
  • The Tooltip's shadow was not visible on Safari.
  • Stories for the Tooltip component use an older Story format.

New Behavior

  • The below-end style for the Tooltip component is now set to below-end.
  • The Tooltip's shadow is now visible on Safari.
  • Stories for the Tooltip component have been updated to use the new Story format and improve type safety.

@radium-v radium-v requested a review from a team as a code owner December 20, 2024 06:26
@github-actions GitHub Actions
Copy link

📊 Bundle size report

✅ No changes found

@github-actions GitHub Actions
Copy link

Pull request demo site: URL

@fabricteam
Copy link
Collaborator

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@radium-v radium-v merged commit 622c4aa into microsoft:master Dec 20, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marchbox marchbox marchbox approved these changes

@davatron5000 davatron5000 davatron5000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@radium-v @fabricteam @davatron5000 @marchbox